Bug fix: catch errors from UserDataBuilder.AddFile

PettitWesley · PettitWesley · commit ad68bda70a35 · 2018-10-24T14:51:44.000-07:00
diff --git a/ecs-cli/modules/cli/cluster/cluster_app.go b/ecs-cli/modules/cli/cluster/cluster_app.go
@@ -511,7 +511,10 @@ func cliFlagsToCfnStackParams(context *cli.Context, cluster, launchType string)
 		// handle extra user data, which is a string slice flag
 		if userDataFiles := context.StringSlice(flags.UserDataFlag); len(userDataFiles) > 0 {
 			for _, file := range userDataFiles {
-				builder.AddFile(file)
+				err := builder.AddFile(file)
+				if err != nil {
+					return nil, err
+				}
 			}
 		}
 		userData, err := builder.Build()

Original file line number	Diff line number	Diff line change
`@@ -511,7 +511,10 @@ func cliFlagsToCfnStackParams(context *cli.Context, cluster, launchType string)`
`511`	`511`	`// handle extra user data, which is a string slice flag`
`512`	`512`	`if userDataFiles := context.StringSlice(flags.UserDataFlag); len(userDataFiles) > 0 {`
`513`	`513`	`for _, file := range userDataFiles {`
`514`		`- builder.AddFile(file)`
	`514`	`+ err := builder.AddFile(file)`
	`515`	`+ if err != nil {`
	`516`	`+ return nil, err`
	`517`	`+ }`
`515`	`518`	`}`
`516`	`519`	`}`
`517`	`520`	`userData, err := builder.Build()`