Add const qualifier to calc_document_size method

tordex · tordex · commit 6f36dd247277 · 2025-06-10T01:46:11.000+03:00
diff --git a/include/litehtml/render_item.h b/include/litehtml/render_item.h
@@ -412,7 +412,7 @@ namespace litehtml
 		std::tuple<int, int> element_static_offset(const std::shared_ptr<litehtml::render_item> &el);
         void add_positioned(const std::shared_ptr<litehtml::render_item> &el);
         void get_redraw_box(litehtml::position& pos, int x = 0, int y = 0);
-        void calc_document_size( litehtml::size& sz, int x = 0, int y = 0 );
+        void calc_document_size( litehtml::size& sz, int x = 0, int y = 0 ) const;
 		virtual void get_inline_boxes( position::vector& /*boxes*/ ) const {};
 		virtual void set_inline_boxes( position::vector& /*boxes*/ ) {};
 		virtual void add_inline_box( const position& /*box*/ ) {};
diff --git a/src/render_item.cpp b/src/render_item.cpp
@@ -707,7 +707,7 @@ void litehtml::render_item::get_redraw_box(litehtml::position& pos, int x /*= 0*
     }
 }
 
-void litehtml::render_item::calc_document_size( litehtml::size& sz, int x /*= 0*/, int y /*= 0*/ )
+void litehtml::render_item::calc_document_size( litehtml::size& sz, int x /*= 0*/, int y /*= 0*/ ) const
 {
 	if(css().get_display() != display_inline && css().get_display() != display_table_row)
 	{
@@ -717,7 +717,7 @@ void litehtml::render_item::calc_document_size( litehtml::size& sz, int x /*= 0*
 			sz.height = std::max(sz.height, y + bottom());
 
 			// All children of tables and blocks with style other than "overflow: visible" are inside element.
-			// We can skip calculating size of children
+			// We can skip calculating the size of children
 			if (src_el()->css().get_overflow() == overflow_visible && src_el()->css().get_display() != display_table)
 			{
 				for (auto &el: m_children)
@@ -730,7 +730,7 @@ void litehtml::render_item::calc_document_size( litehtml::size& sz, int x /*= 0*
 	{
 		position::vector boxes;
 		get_inline_boxes(boxes);
-		for(auto& box : boxes)
+		for(const auto& box : boxes)
 		{
 			sz.width = std::max(sz.width, x + box.x + box.width);
 			sz.height = std::max(sz.height, y + box.y + box.height);

Original file line number	Diff line number	Diff line change
`@@ -707,7 +707,7 @@ void litehtml::render_item::get_redraw_box(litehtml::position& pos, int x /= 0`
`707`	`707`	`}`
`708`	`708`	`}`
`709`	`709`
`710`		`-void litehtml::render_item::calc_document_size( litehtml::size& sz, int x /= 0/, int y /= 0/ )`
	`710`	`+void litehtml::render_item::calc_document_size( litehtml::size& sz, int x /= 0/, int y /= 0/ ) const`
`711`	`711`	`{`
`712`	`712`	`if(css().get_display() != display_inline && css().get_display() != display_table_row)`
`713`	`713`	`{`
`@@ -717,7 +717,7 @@ void litehtml::render_item::calc_document_size( litehtml::size& sz, int x /= 0`
`717`	`717`	`sz.height = std::max(sz.height, y + bottom());`
`718`	`718`
`719`	`719`	`// All children of tables and blocks with style other than "overflow: visible" are inside element.`
`720`		`- // We can skip calculating size of children`
	`720`	`+ // We can skip calculating the size of children`
`721`	`721`	`if (src_el()->css().get_overflow() == overflow_visible && src_el()->css().get_display() != display_table)`
`722`	`722`	`{`
`723`	`723`	`for (auto &el: m_children)`
`@@ -730,7 +730,7 @@ void litehtml::render_item::calc_document_size( litehtml::size& sz, int x /= 0`
`730`	`730`	`{`
`731`	`731`	`position::vector boxes;`
`732`	`732`	`get_inline_boxes(boxes);`
`733`		`- for(auto& box : boxes)`
	`733`	`+ for(const auto& box : boxes)`
`734`	`734`	`{`
`735`	`735`	`sz.width = std::max(sz.width, x + box.x + box.width);`
`736`	`736`	`sz.height = std::max(sz.height, y + box.y + box.height);`