Skip to content

<tr> borders should be ignored #357

@djrecipe

Description

@djrecipe

First off, thank you for still actively developing this. I am interested in becoming a contributor and I may investigate this issue as time permits.

Issue

HTML <tr> elements don't support border styling, and thus should not invoke document_container::draw_borders()

Resources

Example HTML

<table class="customerInfo">
    <tr>
        <td style="width: 50%" class="addressInfo">
            <dl>
                <dt>Navn Navnesen Navnesen</dt>
                <dt>Vallatorpsv&#228;gen 218</dt>
                <dt>18752 T&#228;by</dt>
                <dt>+461231231</dt>
                <dt>name.name@outlook.com</dt>
            </dl>
            <dl>
                <dt></dt>
                <dt></dt>
            </dl>
        </td>
        <td style="width: 50%">
            <table class="offerInfo">
                <tr style="border-bottom: 2px solid black;">
                    <td style="font-family:Helvetica; font-size: 20px; font-weight: bold;">Erbjudande</td>
                    <td></td>
                </tr>
                <tr>
                    <td style="padding-top: 4px">Referens</td>
                    <td style="padding-top: 4px">5c0d</td>
                </tr>

                <tr>
                    <td>Upprättad</td>
                    <td>08. December 2022</td>
                </tr>
                <tr>
                    <td>Giltig till</td>
                    <td><b>16. December 2022</b></td>
                </tr>
                <tr>

                    <td style="vertical-align:top">Kontakt</td>
                    <td>
                        <table class="offerStoreInfo">
                            <tr>
                                <td></td>
                            </tr>
                            <tr>
                                <td>Telefon: </td>
                            </tr>
                            <tr>
                                <td></td>
                            </tr>
                        </table>
                    </td>
                </tr>
                <tr>
                    <td style="vertical-align:top">Butik</td>
                    <td>
                        <table class="offerStoreInfo">
                            <tr>
                                <td>2047 Elgiganten H&#228;ggvik</td>
                            </tr>
                            <tr>
                                <td>nor vegen 141, 191 62 hagg</td>
                            </tr>
                        </table>
                    </td>
                </tr>
            </table>
        </td>
    </tr>
</table>

How chrome displays it
chrome_fyuA0CAGhr

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions