avoid infinite loop

caillou · caillou · commit 167938d8ac6c · 2015-05-05T13:49:03.000+02:00
The following code lead to an infinite loop:

```javascript
crop.setImage('/images/storytelling-painting.jpg')
crop.setRatio(16/9)
```
diff --git a/src/crop.coffee b/src/crop.coffee
@@ -15,15 +15,16 @@ module.exports = class Crop
       @outlineCssClass = 'crop-outline--active'
 
       # State
-      @isReady = false
       @isPanning = false
       @initialCrop = crop
 
       # Events
-      @readyEvent = $.Callbacks('memory once')
       @loadEvent = $.Callbacks()
       @changeEvent = $.Callbacks()
 
+      # Sets up the ready event and state
+      @initializeReadyState()
+
       # Confguration
       @zoomInStep = zoomStep
       @zoomOutStep = 1 / @zoomInStep
@@ -44,11 +45,17 @@ module.exports = class Crop
       @setImage(url)
 
 
+  initializeReadyState: ->
+    @isReady = false
+    @readyEvent?.empty()
+    @readyEvent = $.Callbacks('memory once')
+
+
   setImage: (url) ->
     return unless url != @preview.url
 
     @preview.reset() if @isInitialized
-    @isReady = false
+    @initializeReadyState()
     @view.addClass(@loadingCssClass)
     @preview.setImage({ url })
 
