Skip to content

Commit 201375a

Browse files
committed
Address review feedback
1 parent c6fdb1a commit 201375a

File tree

1 file changed

+1
-4
lines changed

1 file changed

+1
-4
lines changed

clang/lib/CIR/CodeGen/CIRGenClass.cpp

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,7 @@ struct DynamicThisUseChecker
141141
// Black-list all explicit and implicit references to 'this'.
142142
//
143143
// Do we need to worry about external references to 'this' derived
144-
// from arbitrary code? If so, then anything which runs arbitrary
144+
// from arbitrary code? If so, then anything which runs arbitrary
145145
// external code might potentially access the vtable.
146146
void VisitCXXThisExpr(const CXXThisExpr *e) { usesThis = true; }
147147
};
@@ -298,7 +298,6 @@ static Address applyNonVirtualAndVirtualOffset(
298298
assert(!nonVirtualOffset.isZero() || virtualOffset != nullptr);
299299

300300
// Compute the offset from the static and dynamic components.
301-
mlir::Value baseOffset;
302301
if (!nonVirtualOffset.isZero()) {
303302
if (virtualOffset) {
304303
cgf.cgm.errorNYI(
@@ -312,8 +311,6 @@ static Address applyNonVirtualAndVirtualOffset(
312311
loc, addr, baseValueTy, nonVirtualOffset.getQuantity(),
313312
assumeNotNull);
314313
}
315-
} else {
316-
baseOffset = virtualOffset;
317314
}
318315

319316
cgf.cgm.errorNYI(loc, "applyNonVirtualAndVirtualOffset: virtual offset");

0 commit comments

Comments
 (0)