[NFC][IR2Vec] Change getSlotIndex parameter from Value* to Value& (#155700)

svkeerthy · web-flow · commit 27f06dd6a7a9 · 2025-08-29T16:54:04.000-07:00
diff --git a/llvm/include/llvm/Analysis/IR2Vec.h b/llvm/include/llvm/Analysis/IR2Vec.h
@@ -227,7 +227,7 @@ class Vocabulary {
   /// or OperandKind in the vocabulary.
   LLVM_ABI static unsigned getSlotIndex(unsigned Opcode);
   LLVM_ABI static unsigned getSlotIndex(Type::TypeID TypeID);
-  LLVM_ABI static unsigned getSlotIndex(const Value *Op);
+  LLVM_ABI static unsigned getSlotIndex(const Value &Op);
 
   /// Accessors to get the embedding for a given entity.
   LLVM_ABI const ir2vec::Embedding &operator[](unsigned Opcode) const;
diff --git a/llvm/lib/Analysis/IR2Vec.cpp b/llvm/lib/Analysis/IR2Vec.cpp
@@ -282,8 +282,8 @@ unsigned Vocabulary::getSlotIndex(Type::TypeID TypeID) {
   return MaxOpcodes + static_cast<unsigned>(getCanonicalTypeID(TypeID));
 }
 
-unsigned Vocabulary::getSlotIndex(const Value *Op) {
-  unsigned Index = static_cast<unsigned>(getOperandKind(Op));
+unsigned Vocabulary::getSlotIndex(const Value &Op) {
+  unsigned Index = static_cast<unsigned>(getOperandKind(&Op));
   assert(Index < MaxOperandKinds && "Invalid OperandKind");
   return MaxOpcodes + MaxCanonicalTypeIDs + Index;
 }
@@ -297,7 +297,7 @@ const Embedding &Vocabulary::operator[](Type::TypeID TypeID) const {
 }
 
 const ir2vec::Embedding &Vocabulary::operator[](const Value &Arg) const {
-  return Vocab[getSlotIndex(&Arg)];
+  return Vocab[getSlotIndex(Arg)];
 }
 
 StringRef Vocabulary::getVocabKeyForOpcode(unsigned Opcode) {
diff --git a/llvm/tools/llvm-ir2vec/llvm-ir2vec.cpp b/llvm/tools/llvm-ir2vec/llvm-ir2vec.cpp
@@ -184,7 +184,7 @@ class IR2VecTool {
         // Add "Arg" relationships
         unsigned ArgIndex = 0;
         for (const Use &U : I.operands()) {
-          unsigned OperandID = Vocabulary::getSlotIndex(U.get());
+          unsigned OperandID = Vocabulary::getSlotIndex(*U);
           unsigned RelationID = ArgRelation + ArgIndex;
           OS << Opcode << '\t' << OperandID << '\t' << RelationID << '\n';
 
diff --git a/llvm/unittests/Analysis/IR2VecTest.cpp b/llvm/unittests/Analysis/IR2VecTest.cpp
@@ -507,23 +507,23 @@ TEST(IR2VecVocabularyTest, SlotIdxMapping) {
 #define EXPECTED_VOCAB_OPERAND_SLOT(X)                                         \
   MaxOpcodes + MaxCanonicalTypeIDs + static_cast<unsigned>(X)
   // Test Function operand
-  EXPECT_EQ(Vocabulary::getSlotIndex(F),
+  EXPECT_EQ(Vocabulary::getSlotIndex(*F),
             EXPECTED_VOCAB_OPERAND_SLOT(Vocabulary::OperandKind::FunctionID));
 
   // Test Constant operand
   Constant *C = ConstantInt::get(Type::getInt32Ty(Ctx), 42);
-  EXPECT_EQ(Vocabulary::getSlotIndex(C),
+  EXPECT_EQ(Vocabulary::getSlotIndex(*C),
             EXPECTED_VOCAB_OPERAND_SLOT(Vocabulary::OperandKind::ConstantID));
 
   // Test Pointer operand
   BasicBlock *BB = BasicBlock::Create(Ctx, "entry", F);
   AllocaInst *PtrVal = new AllocaInst(Type::getInt32Ty(Ctx), 0, "ptr", BB);
-  EXPECT_EQ(Vocabulary::getSlotIndex(PtrVal),
+  EXPECT_EQ(Vocabulary::getSlotIndex(*PtrVal),
             EXPECTED_VOCAB_OPERAND_SLOT(Vocabulary::OperandKind::PointerID));
 
   // Test Variable operand (function argument)
   Argument *Arg = F->getArg(0);
-  EXPECT_EQ(Vocabulary::getSlotIndex(Arg),
+  EXPECT_EQ(Vocabulary::getSlotIndex(*Arg),
             EXPECTED_VOCAB_OPERAND_SLOT(Vocabulary::OperandKind::VariableID));
 #undef EXPECTED_VOCAB_OPERAND_SLOT
 }

Original file line number	Diff line number	Diff line change
`@@ -282,8 +282,8 @@ unsigned Vocabulary::getSlotIndex(Type::TypeID TypeID) {`
`282`	`282`	`return MaxOpcodes + static_cast<unsigned>(getCanonicalTypeID(TypeID));`
`283`	`283`	`}`
`284`	`284`
`285`		`-unsigned Vocabulary::getSlotIndex(const Value *Op) {`
`286`		`- unsigned Index = static_cast<unsigned>(getOperandKind(Op));`
	`285`	`+unsigned Vocabulary::getSlotIndex(const Value &Op) {`
	`286`	`+ unsigned Index = static_cast<unsigned>(getOperandKind(&Op));`
`287`	`287`	`assert(Index < MaxOperandKinds && "Invalid OperandKind");`
`288`	`288`	`return MaxOpcodes + MaxCanonicalTypeIDs + Index;`
`289`	`289`	`}`
`@@ -297,7 +297,7 @@ const Embedding &Vocabulary::operator[](Type::TypeID TypeID) const {`
`297`	`297`	`}`
`298`	`298`
`299`	`299`	`const ir2vec::Embedding &Vocabulary::operator[](const Value &Arg) const {`
`300`		`- return Vocab[getSlotIndex(&Arg)];`
	`300`	`+ return Vocab[getSlotIndex(Arg)];`
`301`	`301`	`}`
`302`	`302`
`303`	`303`	`StringRef Vocabulary::getVocabKeyForOpcode(unsigned Opcode) {`