-
Notifications
You must be signed in to change notification settings - Fork 14.9k
Closed as not planned
Labels
backend:loongarchquestionA question, not bug report. Check out https://llvm.org/docs/GettingInvolved.html instead!A question, not bug report. Check out https://llvm.org/docs/GettingInvolved.html instead!
Description
I noticed that commit 33388ae changed the llvm/lib/Target/LoongArch/TargetInfo/LoongArchTargetInfo.cpp file, changing "LoongArch (64-bit)" to "64-bit LoongArch" Is there any special reason for this?
extern "C" LLVM_EXTERNAL_VISIBILITY void LLVMInitializeLoongArchTargetInfo() {
RegisterTarget<Triple::loongarch32, /*HasJIT=*/false> X(
- getTheLoongArch32Target(), "loongarch32", "LoongArch (32-bit)",
+ getTheLoongArch32Target(), "loongarch32", "32-bit LoongArch",
"LoongArch");
RegisterTarget<Triple::loongarch64, /*HasJIT=*/false> Y(
- getTheLoongArch64Target(), "loongarch64", "LoongArch (64-bit)",
+ getTheLoongArch64Target(), "loongarch64", "64-bit LoongArch",
"LoongArch");
}
My personal understanding:
Generally speaking, 32-bit LoongArch / 64-bit LoongArch is a subset of LoongArch; wouldn’t it be more reasonable to place it afterwards(LoongArch 64-bit)?
Putting it in front seems to emphasize the differences in instruction sets more, such as between Itanium architecture and x86 architecture.
Thank you.
Metadata
Metadata
Assignees
Labels
backend:loongarchquestionA question, not bug report. Check out https://llvm.org/docs/GettingInvolved.html instead!A question, not bug report. Check out https://llvm.org/docs/GettingInvolved.html instead!