Skip to content

WIP: feat(lambda): Use Lambda Runtime Emulator Interface v2 #12736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 18 commits into
base: master
Choose a base branch
from

Conversation

gregfurman
Copy link
Contributor

Motivation

Currently a WIP. This PR was created to trigger a CI/CD run with the new Lambda RIE v2 enabled by default.

Changes

@gregfurman gregfurman self-assigned this Jun 10, 2025
@gregfurman gregfurman added aws:lambda AWS Lambda semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases labels Jun 10, 2025
Copy link

github-actions bot commented Jun 10, 2025

Test Results - Preflight, Unit

21 613 tests  +18   19 958 ✅ +18   6m 19s ⏱️ ±0s
     1 suites ± 0    1 655 💤 ± 0 
     1 files   ± 0        0 ❌ ± 0 

Results for commit 88b413e. ± Comparison against base commit 3a5f08b.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jun 10, 2025

Test Results (MA/MR) - Preflight, Unit

21 613 tests   19 958 ✅  6m 14s ⏱️
     1 suites   1 655 💤
     1 files         0 ❌

Results for commit 88b413e.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jun 10, 2025

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 9s ⏱️ -2s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 88b413e. ± Comparison against base commit 3a5f08b.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jun 10, 2025

Test Results (amd64, MA/MR) - Acceptance

7 tests   5 ✅  3m 12s ⏱️
1 suites  2 💤
1 files    0 ❌

Results for commit 88b413e.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jun 10, 2025

Test Results (MA/MR) - Alternative Providers

987 tests   584 ✅  23m 18s ⏱️
  4 suites  403 💤
  4 files      0 ❌

Results for commit 88b413e.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jun 10, 2025

Test Results - Alternative Providers

987 tests   584 ✅  22m 18s ⏱️
  4 suites  403 💤
  4 files      0 ❌

Results for commit 88b413e.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jun 10, 2025

Test Results (amd64, MA/MR) - Integration, Bootstrap

    5 files      5 suites   2h 21m 12s ⏱️
5 229 tests 4 303 ✅ 924 💤 2 ❌
5 235 runs  4 303 ✅ 930 💤 2 ❌

For more details on these failures, see this check.

Results for commit 88b413e.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jun 10, 2025

Test Results (amd64) - Integration, Bootstrap

    5 files      5 suites   2h 25m 50s ⏱️
5 229 tests 4 303 ✅ 924 💤 2 ❌
5 235 runs  4 303 ✅ 930 💤 2 ❌

For more details on these failures, see this check.

Results for commit 88b413e.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jun 10, 2025

LocalStack Community integration with Pro

    2 files  ±0      2 suites  ±0   1h 44m 40s ⏱️ + 1m 22s
4 872 tests ±0  4 099 ✅ +4  772 💤  - 5  1 ❌ +1 
4 874 runs  ±0  4 099 ✅ +4  774 💤  - 5  1 ❌ +1 

For more details on these failures, see this check.

Results for commit 88b413e. ± Comparison against base commit 3a5f08b.

♻️ This comment has been updated with latest results.

Comment on lines +3735 to +3740
"errorMessage": "[Errno 13] Permission denied: '/proc/1/environ'",
"errorType": "PermissionError",
"requestId": "<uuid:2>",
"stackTrace": [
" File \"/var/task/handler.py\", line 3, in handler\n with open(f\"/proc/{pid}/environ\", mode=\"rt\") as f:\n"
]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dfangl @joe4dev Seems like this test now expects a permissions error 🤔 Any pointers on how we should be configuring the user permissions when accessing the lambda FS? We currently set the following:

https://github.com/localstack/lambda-runtime-init/blob/9be92e099e99c9973f2e1730d1af6d4ffd769bb2/cmd/localstack/main.go#L155-L169

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we parity-test/inspect this, or does the permission prohibit that?
If not, @dfangl might have a better guess. Maybe, try 600 🤷‍♂️

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the tests makes no longer sense then - it was mean to introspect the environment of the init process, if that is no longer possible in AWS, there is no real point (although we could try to hide it in our containers as well, I don't necessarily see this as a priority)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aws:lambda AWS Lambda semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants