Add provider info to service request counter #12740
Draft
+3
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results - Preflight, Unit21 613 tests ±0 19 956 ✅ - 2 6m 28s ⏱️ +15s For more details on these failures, see this check. Results for commit b6d93f4. ± Comparison against base commit 5b623bf. |
mmaureenliu
reviewed
Jun 11, 2025
| @@ -42,13 +42,15 @@ def __call__(self, chain: HandlerChain, context: RequestContext, response: Respo | |||
| err_type = self._get_err_type(context, response) if response.status_code >= 400 else None | |||
| service_name = context.operation.service_model.service_name | |||
| operation_name = context.operation.name | |||
| provider = config.SERVICE_PROVIDER_CONFIG.get_provider(service_name) | |||
There was a problem hiding this comment.
this line seems to suggest that there's a 1:1 relationship of service_name to provider, which I think is not true - did I misread the function or the 1:1 relationship actually is true in the community version?
There was a problem hiding this comment.
In a running instance the relation is 1:1. Only one provider can be active at once. The active provider is defined in the config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
/cc @mmaureenliu
Changes