-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Update test durations automatically based on latest durations from master #12748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Test Results - Preflight, Unit21 613 tests ±0 19 957 ✅ - 1 6m 45s ⏱️ -15s For more details on these errors, see this check. Results for commit 75f3790. ± Comparison against base commit 3bbf944. ♻️ This comment has been updated with latest results. |
Test Results - Alternative Providers987 tests 589 ✅ 30m 17s ⏱️ Results for commit b22b9a9. |
Test Results (amd64) - Integration, Bootstrap 5 files 5 suites 2h 21m 21s ⏱️ Results for commit b22b9a9. |
Test Results (amd64, MA/MR) - Integration, Bootstrap 5 files ±0 5 suites ±0 2h 21m 17s ⏱️ - 1m 9s Results for commit 75f3790. ± Comparison against base commit 3bbf944. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! This is really cool! The update-test-durations.yml
might be something we want to consider generalizing and moving to our meta
repository in the future to use it in other repositories as well 🤩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just some minor non-blocking suggestions :)
- name: Latest run-id from community repository | ||
run: | | ||
latest_workflow_id=$(curl -s https://api.github.com/repos/localstack/localstack/actions/workflows \ | ||
| jq '.workflows[] | select(.name=="AWS / Build, Test, Push").id') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: I think you can use the aws-test.yml
filename here as well. This might make it more stable in regards to name changes
latest_workflow_id=$(curl -s https://api.github.com/repos/localstack/localstack/actions/workflows \ | ||
| jq '.workflows[] | select(.name=="AWS / Build, Test, Push").id') | ||
latest_run_id=$(curl -s \ | ||
"https://api.github.com/repos/localstack/localstack/actions/workflows/${latest_workflow_id}/runs?branch=master&status=success&per_page=30" \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
q: What happens if the latest workflow doesn't have a successful attempt?
path: localstack | ||
add-paths: .test_durations | ||
labels: "semver: patch, area: testing, area: ci" | ||
token: ${{ secrets.GITHUB_TOKEN }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: You could use PRO_ACCESS_TOKEN
here so that it's using the PAT of @localstack-bot. This way the PR author should be the bot instead of github-actions
Motivation
While switching from CircleCI to GitHub Actions, I saw that the test durations file hadn’t been updated in about a year. Since then, we’ve added a lot of new tests. This pull request adds a workflow that downloads test durations from the latest scheduled run on the master branch, combines them, and creates a PR with the updated test durations file. New workflow is scheduled to run every month.
Changes
Testing
Tested in a forked repostiory.