Skip to content

Commit 48d7f86

Browse files
author
Robert Stanfield
committed
Delegate cache busting query string to the UrlGenerator
1 parent 673a9c5 commit 48d7f86

File tree

1 file changed

+12
-15
lines changed

1 file changed

+12
-15
lines changed

src/JavascriptRenderer.php

Lines changed: 12 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ class JavascriptRenderer extends BaseJavascriptRenderer
1212
// Use XHR handler by default, instead of jQuery
1313
protected $ajaxHandlerBindToJquery = false;
1414
protected $ajaxHandlerBindToXHR = true;
15-
15+
1616
/** @var \Illuminate\Routing\UrlGenerator */
1717
protected $url;
1818

@@ -43,20 +43,17 @@ public function renderHead()
4343
return parent::renderHead();
4444
}
4545

46-
$jsModified = $this->getModifiedTime('js');
47-
$cssModified = $this->getModifiedTime('css');
48-
49-
$html = '';
50-
$html .= sprintf(
51-
'<link rel="stylesheet" type="text/css" href="%s?%s">' . "\n",
52-
$this->url->route('debugbar.assets.css'),
53-
$cssModified
54-
);
55-
$html .= sprintf(
56-
'<script type="text/javascript" src="%s?%s"></script>' . "\n",
57-
$this->url->route('debugbar.assets.js'),
58-
$jsModified
59-
);
46+
$cssRoute = $this->url->route('debugbar.assets.css', [
47+
'v' => $this->getModifiedTime('css')
48+
]);
49+
50+
$jsRoute = $this->url->route('debugbar.assets.js', [
51+
'v' => $this->getModifiedTime('js')
52+
]);
53+
54+
$html = '';
55+
$html .= "<link rel='stylesheet' type='text/css' href='{$cssRoute}'>";
56+
$html .= "<script type='text/javascript' src='{$jsRoute}'></script>";
6057

6158
if ($this->isJqueryNoConflictEnabled()) {
6259
$html .= '<script type="text/javascript">jQuery.noConflict(true);</script>' . "\n";

0 commit comments

Comments
 (0)