Fixed bug when calling defineReactive on non-existent field with convertAllProperties on

jdavidberger · jdavidberger · commit 00d11a9e0e8d · 2015-11-10T23:18:42.000-07:00
diff --git a/src/observer/index.js b/src/observer/index.js
@@ -181,8 +181,8 @@ function defineReactive (obj, key, val) {
     if (property && property.configurable === false) {
       return
     }
-    getter = property.get
-    setter = property.set
+    getter = property && property.get
+    setter = property && property.set
   }
 
   var childOb = Observer.create(val)
diff --git a/test/unit/specs/directives/public/for/for_spec.js b/test/unit/specs/directives/public/for/for_spec.js
@@ -1,5 +1,6 @@
 var _ = require('../../../../../../src/util')
 var Vue = require('../../../../../../src/vue')
+var config = require('../../../../../../src/config')
 
 if (_.inBrowser) {
   describe('v-for', function () {
@@ -8,6 +9,7 @@ if (_.inBrowser) {
     beforeEach(function () {
       el = document.createElement('div')
       spyOn(_, 'warn')
+      config.convertAllProperties = false
     })
 
     it('objects', function (done) {
@@ -21,6 +23,18 @@ if (_.inBrowser) {
       assertMutations(vm, el, done)
     })
 
+    it('objects with convertAllProperties on', function (done) {
+      config.convertAllProperties = true
+      var vm = new Vue({
+        el: el,
+        data: {
+          items: [{a: 1}, {a: 2}]
+        },
+        template: '<div v-for="item in items">{{$index}} {{item.a}}</div>'
+      })
+      assertMutations(vm, el, done)
+    })
+
     it('primitives', function (done) {
       var vm = new Vue({
         el: el,

Original file line number	Diff line number	Diff line change
`@@ -181,8 +181,8 @@ function defineReactive (obj, key, val) {`
`181`	`181`	`if (property && property.configurable === false) {`
`182`	`182`	`return`
`183`	`183`	`}`
`184`		`- getter = property.get`
`185`		`- setter = property.set`
	`184`	`+ getter = property && property.get`
	`185`	`+ setter = property && property.set`
`186`	`186`	`}`
`187`	`187`
`188`	`188`	`var childOb = Observer.create(val)`