fix SQL syntax error on AjaxDatatablesRails#search_condition if

M. Saiqul Haq · M. Saiqul Haq · commit eb6efac3ba00 · 2014-10-30T11:29:06.000+07:00
db_adapter is mysql
add initializer generator for configure global setting configuration
diff --git a/lib/ajax-datatables-rails.rb b/lib/ajax-datatables-rails.rb
@@ -1,8 +1,9 @@
 require 'ajax-datatables-rails/version'
+require 'ajax-datatables-rails/config'
 require 'ajax-datatables-rails/base'
 require 'ajax-datatables-rails/extensions/simple_paginator'
 require 'ajax-datatables-rails/extensions/kaminari'
 require 'ajax-datatables-rails/extensions/will_paginate'
 
 module AjaxDatatablesRails
-end
+end
diff --git a/lib/ajax-datatables-rails/base.rb b/lib/ajax-datatables-rails/base.rb
@@ -11,6 +11,10 @@ def initialize(view, options = {})
       @options = options
     end
 
+    def config
+      @config ||= AjaxDatatablesRails.config
+    end
+
     def sortable_columns
       @sortable_columns ||= []
     end
@@ -101,7 +105,18 @@ def build_conditions_for(query)
     def search_condition(column, value)
       model, column = column.split('.')
       model = model.singularize.titleize.gsub( / /, '' ).constantize
-      casted_column = ::Arel::Nodes::NamedFunction.new('CAST', [model.arel_table[column.to_sym].as('VARCHAR')])
+
+      # because particular commit is based on postgre, so that's why use VARCHAR
+      # but we we need to use CHAR typecast on mysql db adapter
+      # or maybe it should
+      #   if :pg
+      #   elsif :mysql
+      #   else
+      if @config.db_adapter == :pg
+        casted_column = ::Arel::Nodes::NamedFunction.new('CAST', [model.arel_table[column.to_sym].as('VARCHAR')])
+      else
+        casted_column = ::Arel::Nodes::NamedFunction.new('CAST', [model.arel_table[column.to_sym].as('CHAR')])
+      end
       casted_column.matches("%#{value}%")
     end
 
diff --git a/lib/ajax-datatables-rails/config.rb b/lib/ajax-datatables-rails/config.rb
@@ -0,0 +1,24 @@
+require 'active_support/configurable'
+
+module AjaxDatatablesRails
+
+  # configure AjaxDatatablesRails global settings
+  #   AjaxDatatablesRails.configure do |config|
+  #     config.db_adapter = :pg
+  #   end
+  def self.configure &block
+    yield @config ||= AjaxDatatablesRails::Configuration.new
+  end
+
+  # AjaxDatatablesRails global settings
+  def self.config
+    @config ||= AjaxDatatablesRails::Configuration.new
+  end
+
+  class Configuration
+    include ActiveSupport::Configurable
+
+    # default db_adapter is pg (postgresql)
+    config_accessor(:db_adapter) { :pg }
+  end
+end
diff --git a/lib/generators/rails/datatable_initializer_generator.rb b/lib/generators/rails/datatable_initializer_generator.rb
@@ -0,0 +1,15 @@
+module Rails
+  module Generators
+    class DatatableInitializerGenerator < ::Rails::Generators::Base
+      source_root File.expand_path(File.join(File.dirname(__FILE__), 'templates'))
+      desc <<DESC
+Description:
+  Creates an initializer file for AjaxDatatablesRails configuration at config/initializers.
+DESC
+
+      def copy_config_file
+        template 'ajax_datatables_rails_config.rb', 'config/initializers/ajax_datatables_rails.rb'
+      end
+    end
+  end
+end
diff --git a/lib/generators/rails/templates/ajax_datatables_rails_config.rb b/lib/generators/rails/templates/ajax_datatables_rails_config.rb
@@ -0,0 +1,3 @@
+AjaxDatatablesRails.configure do |config|
+  #config.db_adapter = :pg
+end
diff --git a/spec/ajax-datatables-rails/ajax_datatables_rails_spec.rb b/spec/ajax-datatables-rails/ajax_datatables_rails_spec.rb
@@ -221,3 +221,38 @@ def self.arel_table
     end
   end
 end
+
+
+describe AjaxDatatablesRails::Configuration do
+  let(:config) { AjaxDatatablesRails::Configuration.new }
+
+  describe "default config" do
+    it "default db_adapter should :pg (postgresql)" do
+      expect(config.db_adapter).to eq(:pg)
+    end
+  end
+
+  describe "custom config" do
+    it 'should accept db_adapter custom value' do
+      config.db_adapter = :mysql2
+      expect(config.db_adapter).to eq(:mysql2)
+    end
+  end
+end
+
+describe AjaxDatatablesRails do
+  describe "configurations" do
+    context "configurable from outside" do
+      before(:each) do
+        AjaxDatatablesRails.configure do |config|
+          config.db_adapter = :mysql2
+        end
+      end
+
+      it "should have custom value" do
+        expect(AjaxDatatablesRails.config.db_adapter).to eq(:mysql2)
+      end
+    end
+
+  end
+end

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+AjaxDatatablesRails.configure do \|config\|`
	`2`	`+ #config.db_adapter = :pg`
	`3`	`+end`