Addressing internal comments, small changes for consistency and comments

JoseAlcerreca · JoseAlcerreca · commit 56abccb386fd · 2016-03-01T13:45:06.000Z
diff --git a/todo-mvp-loaders/app/src/androidTestMock/java/com/example/android/architecture/blueprints/todoapp/taskdetail/TaskDetailScreenTest.java b/todo-mvp-loaders/app/src/androidTestMock/java/com/example/android/architecture/blueprints/todoapp/taskdetail/TaskDetailScreenTest.java
@@ -135,6 +135,7 @@ public void orientationChange_menuAndTaskPersist() {
 
         TestUtils.rotateOrientation(mTaskDetailActivityTestRule);
 
+        // Check that the task is shown
         onView(withId(R.id.task_detail_title)).check(matches(withText(TASK_TITLE)));
         onView(withId(R.id.task_detail_description)).check(matches(withText(TASK_DESCRIPTION)));
 
diff --git a/todo-mvp-loaders/app/src/main/java/com/example/android/architecture/blueprints/todoapp/taskdetail/TaskDetailPresenter.java b/todo-mvp-loaders/app/src/main/java/com/example/android/architecture/blueprints/todoapp/taskdetail/TaskDetailPresenter.java
@@ -64,10 +64,6 @@ public TaskDetailPresenter(@Nullable String taskId,
 
     @Override
     public void start() {
-        openTask();
-    }
-
-    private void openTask() {
         mLoaderManager.initLoader(TASK_QUERY, null, this);
     }
 
diff --git a/todo-mvp/app/src/androidTestMock/java/com/example/android/architecture/blueprints/todoapp/taskdetail/TaskDetailScreenTest.java b/todo-mvp/app/src/androidTestMock/java/com/example/android/architecture/blueprints/todoapp/taskdetail/TaskDetailScreenTest.java
@@ -135,6 +135,7 @@ public void orientationChange_menuAndTaskPersist() {
 
         TestUtils.rotateOrientation(mTaskDetailActivityTestRule);
 
+        // Check that the task is shown
         onView(withId(R.id.task_detail_title)).check(matches(withText(TASK_TITLE)));
         onView(withId(R.id.task_detail_description)).check(matches(withText(TASK_DESCRIPTION)));
 

Original file line number	Diff line number	Diff line change
`@@ -64,10 +64,6 @@ public TaskDetailPresenter(@Nullable String taskId,`
`64`	`64`
`65`	`65`	`@Override`
`66`	`66`	`public void start() {`
`67`		`- openTask();`
`68`		`- }`
`69`		`-`
`70`		`- private void openTask() {`
`71`	`67`	`mLoaderManager.initLoader(TASK_QUERY, null, this);`
`72`	`68`	`}`
`73`	`69`