malmstein · malmstein · commit be838b0d0b02 · 2016-04-12T15:41:49.000+01:00
cleaning the constructor a little bit
diff --git a/todoapp/app/src/main/java/com/example/android/architecture/blueprints/todoapp/tasks/TaskFilter.java b/todoapp/app/src/main/java/com/example/android/architecture/blueprints/todoapp/tasks/TaskFilter.java
@@ -9,7 +9,7 @@ public class TaskFilter {
     private TasksFilterType tasksFilterType = TasksFilterType.ALL_TASKS;
     private Bundle filterExtras;
 
-    public TaskFilter(Bundle extras) {
+    private TaskFilter(Bundle extras) {
         this.filterExtras = extras;
         this.tasksFilterType = (TasksFilterType) extras.getSerializable(TasksOperations.KEY_TASK_FILTER);
     }
diff --git a/todoapp/app/src/main/java/com/example/android/architecture/blueprints/todoapp/tasks/TasksActivity.java b/todoapp/app/src/main/java/com/example/android/architecture/blueprints/todoapp/tasks/TasksActivity.java
@@ -79,20 +79,20 @@ protected void onCreate(Bundle savedInstanceState) {
         LoaderProvider loaderProvider = new LoaderProvider(getApplicationContext());
         TasksOperations tasksOperations = new TasksOperations(loaderProvider, getSupportLoaderManager());
 
-        mTasksPresenter = new TasksPresenter(
-                tasksOperations,
-                repository,
-                tasksFragment,
-                TaskFilter.from(TasksFilterType.ALL_TASKS)
-        );
-
         // Load previously saved state, if available.
+        TaskFilter taskFilter = TaskFilter.from(TasksFilterType.ALL_TASKS);
         if (savedInstanceState != null) {
             TasksFilterType currentFiltering =
                     (TasksFilterType) savedInstanceState.getSerializable(CURRENT_FILTERING_KEY);
-            TaskFilter taskFilter = TaskFilter.from(currentFiltering);
-            mTasksPresenter.setFiltering(taskFilter);
+            taskFilter = TaskFilter.from(currentFiltering);
         }
+
+        mTasksPresenter = new TasksPresenter(
+                tasksOperations,
+                repository,
+                tasksFragment,
+                taskFilter
+        );
     }
 
     @Override

Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,7 @@ public class TaskFilter {`
`9`	`9`	`private TasksFilterType tasksFilterType = TasksFilterType.ALL_TASKS;`
`10`	`10`	`private Bundle filterExtras;`
`11`	`11`
`12`		`- public TaskFilter(Bundle extras) {`
	`12`	`+ private TaskFilter(Bundle extras) {`
`13`	`13`	`this.filterExtras = extras;`
`14`	`14`	`this.tasksFilterType = (TasksFilterType) extras.getSerializable(TasksOperations.KEY_TASK_FILTER);`
`15`	`15`	`}`