Skip to content

Commit a1ac97b

Browse files
authored
Merge pull request apolloconfig#645 from nobodyiam/admin-service-address-locator
use RestTemplateFactory to create rest template
2 parents 8db5e26 + 0cddf9c commit a1ac97b

File tree

1 file changed

+3
-13
lines changed

1 file changed

+3
-13
lines changed

apollo-portal/src/main/java/com/ctrip/framework/apollo/portal/component/AdminServiceAddressLocator.java

Lines changed: 3 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@
3232
@Component
3333
public class AdminServiceAddressLocator {
3434

35-
private static final int DEFAULT_TIMEOUT_MS = 1000;
3635
private static final long NORMAL_REFRESH_INTERVAL = 5 * 60 * 1000;
3736
private static final long OFFLINE_REFRESH_INTERVAL = 10 * 1000;
3837
private static final int RETRY_TIMES = 3;
@@ -48,24 +47,15 @@ public class AdminServiceAddressLocator {
4847
private HttpMessageConverters httpMessageConverters;
4948
@Autowired
5049
private PortalSettings portalSettings;
50+
@Autowired
51+
private RestTemplateFactory restTemplateFactory;
5152

5253
@PostConstruct
5354
public void init() {
5455
allEnvs = portalSettings.getAllEnvs();
5556

5657
//init restTemplate
57-
restTemplate = new RestTemplate(httpMessageConverters.getConverters());
58-
if (restTemplate.getRequestFactory() instanceof SimpleClientHttpRequestFactory) {
59-
SimpleClientHttpRequestFactory rf =
60-
(SimpleClientHttpRequestFactory) restTemplate.getRequestFactory();
61-
rf.setReadTimeout(DEFAULT_TIMEOUT_MS);
62-
rf.setConnectTimeout(DEFAULT_TIMEOUT_MS);
63-
} else if (restTemplate.getRequestFactory() instanceof HttpComponentsClientHttpRequestFactory) {
64-
HttpComponentsClientHttpRequestFactory rf =
65-
(HttpComponentsClientHttpRequestFactory) restTemplate.getRequestFactory();
66-
rf.setReadTimeout(DEFAULT_TIMEOUT_MS);
67-
rf.setConnectTimeout(DEFAULT_TIMEOUT_MS);
68-
}
58+
restTemplate = restTemplateFactory.getObject();
6959

7060
refreshServiceAddressService =
7161
Executors.newScheduledThreadPool(1, ApolloThreadFactory.create("ServiceLocator", false));

0 commit comments

Comments
 (0)