Skip to content

Commit cf7633e

Browse files
committed
Some enhancements to contribution guidelins robotframework#1805
1 parent 124247f commit cf7633e

File tree

1 file changed

+32
-19
lines changed

1 file changed

+32
-19
lines changed

CONTRIBUTING.rst

Lines changed: 32 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,16 @@
1-
Contributing to Robot Framework
2-
===============================
1+
Contribution guidelines
2+
=======================
33

44
These guidelines instruct how to submit issues and contribute code to the
55
`Robot Framework project <https://github.com/robotframework/robotframework>`_.
66
There are also many other projects in the larger `Robot Framework ecosystem
77
<http://robotframework.org>`_ that you can contribute to. If you notice
88
a library or tool missing, there is hardly any better way to contribute
9-
than creating your own project.
9+
than creating your own project. Other great ways to contribute include
10+
answering questions and participating discussion on `robotframework-users
11+
<https://groups.google.com/forum/#!forum/robotframework-users>`_ mailing list
12+
and other forums as well as spreading the word about the framework one way or
13+
the other.
1014

1115
.. contents::
1216
:depth: 2
@@ -18,11 +22,10 @@ Submitting issues
1822
Bugs and enhancements are tracked in the `issue tracker
1923
<https://github.com/robotframework/robotframework/issues>`_. If you are
2024
unsure if something is a bug or is a feature worth implementing, you can
21-
first ask on `robotframework-users
22-
<https://groups.google.com/forum/#!forum/robotframework-users>`_ mailing
23-
list or IRC (#robotframework on irc.freenode.net). These and other
24-
similar forums, not the issue tracker, are also places where to ask general
25-
questions.
25+
first ask on `robotframework-users`_ list or `IRC
26+
<http://webchat.freenode.net/?channels=robotframework&prompt=1>`_
27+
(#robotframework on irc.freenode.net). These and other similar forums,
28+
not the issue tracker, are also places where to ask general questions.
2629

2730
Before submitting a new issue, it is always a good idea to check is the
2831
same bug or enhancement already reported. If it is, please add your comments
@@ -95,8 +98,8 @@ recommend to create dedicated branches for pull requests instead of creating
9598
them based on the master branch. This is especially important if you plan to
9699
work on multiple pull requests at the same time.
97100

98-
Style guidelines
99-
~~~~~~~~~~~~~~~~
101+
Coding conventions
102+
~~~~~~~~~~~~~~~~~~
100103

101104
Robot Framework uses the general Python code conventions defined in `PEP-8
102105
<https://www.python.org/dev/peps/pep-0008/>`_. In addition to that, we try
@@ -145,17 +148,27 @@ Libraries
145148
If `standard libraries
146149
<http://robotframework.org/robotframework/#standard-libraries>`_ distributed
147150
with Robot Framework are enhanced, also their documentation needs to
148-
be updated. Keyword documentation is created using docstrings and it must
149-
use Robot's own `documentation formatting
150-
<http://robotframework.org/robotframework/latest/RobotFrameworkUserGuide.html#documentation-formatting>`_.
151+
be updated. Keyword documentation is created from docstrings using the `Libdoc
152+
<http://robotframework.org/robotframework/latest/RobotFrameworkUserGuide.html#libdoc>`_
153+
tool. Documentation must use Robot Framework's own `documentation formatting
154+
<http://robotframework.org/robotframework/latest/RobotFrameworkUserGuide.html#documentation-formatting>`_
155+
and follow these guidelines:
151156

152-
Examples are recommend whenever the new keyword or enhanced functionality is
153-
not trivial. All new enhancements or changes should have a note like
154-
``New in Robot Framework 2.9.`` somewhere in the documentation. Existing
155-
documentation can be used as an example.
157+
- Other keywords and sections in the library introduction can be referenced
158+
with internal links created with backticks like ```Example Keyword```
156159

157-
Library documentation can be created using `<doc/libraries/lib2html.py>`_
158-
script and should be verified before the code is committed.
160+
- When referring to arguments, argument names must use in inline code style
161+
created with double backticks like ````argument````.
162+
163+
- Examples are recommend whenever the new keyword or enhanced functionality is
164+
not trivial.
165+
166+
- All new enhancements or changes should have a note telling when the change
167+
was introduced. Often adding something like ``New in Robot Framework 2.9.``
168+
is enough.
169+
170+
Library documentation can be easily created using `<doc/libraries/lib2html.py>`_
171+
script. Resulting docs should be verified before the code is committed.
159172

160173
API documentation
161174
'''''''''''''''''

0 commit comments

Comments
 (0)