c init 0

Yusuke Sugomori · Yusuke Sugomori · commit 41c7a0c5fd13 · 2013-02-12T15:51:16.000+09:00
diff --git a/c/DBN.c b/c/DBN.c
@@ -302,12 +302,14 @@ void RBM__construct(RBM* this, int N, int n_visible, int n_hidden, \
 
   if(hbias == NULL) {
     this->hbias = (double *)malloc(sizeof(double) * n_hidden);
+    for(i=0; i<n_hidden; i++) this->hbias[i] = 0;
   } else {
     this->hbias = hbias;
   }
 
   if(vbias == NULL) {
     this->vbias = (double *)malloc(sizeof(double) * n_visible);
+    for(i=0; i<n_visible; i++) this->vbias[i] = 0;
   } else {
     this->vbias = vbias;
   }
@@ -430,7 +432,7 @@ void RBM_reconstruct(RBM* this, int *v, double *reconstructed_v) {
 
 // LogisticRegression
 void LogisticRegression__construct(LogisticRegression *this, int N, int n_in, int n_out) {
-  int i;
+  int i, j;
   this->N = N;
   this->n_in = n_in;
   this->n_out = n_out;
@@ -439,6 +441,13 @@ void LogisticRegression__construct(LogisticRegression *this, int N, int n_in, in
   this->W[0] = (double *)malloc(sizeof(double) * n_in * n_out);
   for(i=0; i<n_out; i++) this->W[i] = this->W[0] + i * n_in;
   this->b = (double *)malloc(sizeof(double) * n_out);
+
+  for(i=0; i<n_out; i++) {
+    for(j=0; j<n_in; j++) {
+      this->W[i][j] = 0;
+    }
+    this->b[i] = 0;
+  }
 }
 
 void LogisticRegression__destruct(LogisticRegression *this) {
@@ -453,6 +462,7 @@ void LogisticRegression_train(LogisticRegression *this, int *x, int *y, double l
   double *dy = (double *)malloc(sizeof(double) * this->n_out);
 
   for(i=0; i<this->n_out; i++) {
+    p_y_given_x[i] = 0;
     for(j=0; j<this->n_in; j++) {
       p_y_given_x[i] += this->W[i][j] * x[j];
     }
@@ -492,6 +502,7 @@ void LogisticRegression_predict(LogisticRegression *this, int *x, double *y) {
   int i,j;
 
   for(i=0; i<this->n_out; i++) {
+    y[i] = 0;
     for(j=0; j<this->n_in; j++) {
       y[i] += this->W[i][j] * x[j];
     }
diff --git a/c/LogisticRegression.c b/c/LogisticRegression.c
@@ -7,7 +7,7 @@ void test_lr(void);
 
 
 void LogisticRegression__construct(LogisticRegression *this, int N, int n_in, int n_out) {
-  int i;
+  int i, j;
   this->N = N;
   this->n_in = n_in;
   this->n_out = n_out;
@@ -16,6 +16,13 @@ void LogisticRegression__construct(LogisticRegression *this, int N, int n_in, in
   this->W[0] = (double *)malloc(sizeof(double) * n_in * n_out);
   for(i=0; i<n_out; i++) this->W[i] = this->W[0] + i * n_in;
   this->b = (double *)malloc(sizeof(double) * n_out);
+
+  for(i=0; i<n_out; i++) {
+    for(j=0; j<n_in; j++) {
+      this->W[i][j] = 0;
+    }
+    this->b[i] = 0;
+  }
 }
 
 void LogisticRegression__destruct(LogisticRegression *this) {
@@ -30,6 +37,7 @@ void LogisticRegression_train(LogisticRegression *this, int *x, int *y, double l
   double *dy = (double *)malloc(sizeof(double) * this->n_out);
 
   for(i=0; i<this->n_out; i++) {
+    p_y_given_x[i] = 0;
     for(j=0; j<this->n_in; j++) {
       p_y_given_x[i] += this->W[i][j] * x[j];
     }
@@ -69,6 +77,7 @@ void LogisticRegression_predict(LogisticRegression *this, int *x, double *y) {
   int i,j;
 
   for(i=0; i<this->n_out; i++) {
+    y[i] = 0;
     for(j=0; j<this->n_in; j++) {
       y[i] += this->W[i][j] * x[j];
     }
diff --git a/c/RBM.c b/c/RBM.c
@@ -60,12 +60,14 @@ void RBM__construct(RBM* this, int N, int n_visible, int n_hidden, \
 
   if(hbias == NULL) {
     this->hbias = (double *)malloc(sizeof(double) * n_hidden);
+    for(i=0; i<n_hidden; i++) this->hbias[i] = 0;
   } else {
     this->hbias = hbias;
   }
 
   if(vbias == NULL) {
     this->vbias = (double *)malloc(sizeof(double) * n_visible);
+    for(i=0; i<n_visible; i++) this->vbias[i] = 0;
   } else {
     this->vbias = vbias;
   }

Original file line number	Diff line number	Diff line change
`@@ -60,12 +60,14 @@ void RBM__construct(RBM* this, int N, int n_visible, int n_hidden, \`
`60`	`60`
`61`	`61`	`if(hbias == NULL) {`
`62`	`62`	`this->hbias = (double )malloc(sizeof(double) n_hidden);`
	`63`	`+ for(i=0; i<n_hidden; i++) this->hbias[i] = 0;`
`63`	`64`	`} else {`
`64`	`65`	`this->hbias = hbias;`
`65`	`66`	`}`
`66`	`67`
`67`	`68`	`if(vbias == NULL) {`
`68`	`69`	`this->vbias = (double )malloc(sizeof(double) n_visible);`
	`70`	`+ for(i=0; i<n_visible; i++) this->vbias[i] = 0;`
`69`	`71`	`} else {`
`70`	`72`	`this->vbias = vbias;`
`71`	`73`	`}`