Skip to content

Commit 3e2ed8c

Browse files
committed
Add test for unicode domain and path arguments to set_cookie
1 parent 2f2659b commit 3e2ed8c

File tree

1 file changed

+15
-1
lines changed

1 file changed

+15
-1
lines changed

tornado/test/web_test.py

Lines changed: 15 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,9 +65,18 @@ class GetCookieHandler(RequestHandler):
6565
def get(self):
6666
self.write(self.get_cookie("foo"))
6767

68+
class SetCookieDomainHandler(RequestHandler):
69+
def get(self):
70+
# unicode domain and path arguments shouldn't break things
71+
# either (see bug #285)
72+
self.set_cookie("unicode_args", "blah", domain=u"foo.com",
73+
path=u"/foo")
74+
75+
6876
return Application([
6977
("/set", SetCookieHandler),
70-
("/get", GetCookieHandler)])
78+
("/get", GetCookieHandler),
79+
("/set_domain", SetCookieDomainHandler)])
7180

7281
def test_set_cookie(self):
7382
response = self.fetch("/set")
@@ -80,6 +89,11 @@ def test_get_cookie(self):
8089
response = self.fetch("/get", headers={"Cookie": "foo=bar"})
8190
self.assertEqual(response.body, b("bar"))
8291

92+
def test_set_cookie_domain(self):
93+
response = self.fetch("/set_domain")
94+
self.assertEqual(response.headers.get_list("Set-Cookie"),
95+
["unicode_args=blah; Domain=foo.com; Path=/foo"])
96+
8397
class AuthRedirectRequestHandler(RequestHandler):
8498
def initialize(self, login_url):
8599
self.login_url = login_url

0 commit comments

Comments
 (0)