use getattr to check for close method in IOLoop.close

minrk · minrk · commit d80fa56c06be · 2013-04-15T18:12:48.000-07:00
instead of catching AttributeError directly
diff --git a/tornado/ioloop.py b/tornado/ioloop.py
@@ -505,9 +505,10 @@ def close(self, all_fds=False):
         if all_fds:
             for fd in self._handlers.keys():
                 try:
-                    try:
-                        fd.close()
-                    except AttributeError:
+                    close_method = getattr(fd, 'close', None)
+                    if close_method is not None:
+                        close_method()
+                    else:
                         os.close(fd)
                 except Exception:
                     gen_log.debug("error closing fd %s", fd, exc_info=True)
