Fixed issue parsing invalid cookies

hoisie · hoisie · commit d3143d37c9b2 · 2010-01-15T07:35:00.000Z
The logger prints the request method
diff --git a/request.go b/request.go
@@ -242,6 +242,9 @@ func (r *Request) parseCookies() (err os.Error) {
             for _, cookie := range (cookies) {
                 cookie = strings.TrimSpace(cookie)
                 parts := strings.Split(cookie, "=", 2)
+                if len(parts) != 2 {
+                    continue
+                }
                 r.Cookies[parts[0]] = parts[1]
             }
         }
diff --git a/web.go b/web.go
@@ -216,7 +216,7 @@ func routeHandler(req *Request, c conn) {
 
     //log the request
     if len(req.URL.RawQuery) == 0 {
-        log.Stdout(requestPath)
+        log.Stdout(req.Method + " " + requestPath)
     } else {
         log.Stdout(requestPath + "?" + req.URL.RawQuery)
     }

Original file line number	Diff line number	Diff line change
`@@ -242,6 +242,9 @@ func (r *Request) parseCookies() (err os.Error) {`
`242`	`242`	`for _, cookie := range (cookies) {`
`243`	`243`	`cookie = strings.TrimSpace(cookie)`
`244`	`244`	`parts := strings.Split(cookie, "=", 2)`
	`245`	`+ if len(parts) != 2 {`
	`246`	`+ continue`
	`247`	`+ }`
`245`	`248`	`r.Cookies[parts[0]] = parts[1]`
`246`	`249`	`}`
`247`	`250`	`}`
Original file line number	Diff line number	Diff line change
`@@ -216,7 +216,7 @@ func routeHandler(req *Request, c conn) {`
`216`	`216`
`217`	`217`	`//log the request`
`218`	`218`	`if len(req.URL.RawQuery) == 0 {`
`219`		`- log.Stdout(requestPath)`
	`219`	`+ log.Stdout(req.Method + " " + requestPath)`
`220`	`220`	`} else {`
`221`	`221`	`log.Stdout(requestPath + "?" + req.URL.RawQuery)`
`222`	`222`	`}`