refactor(isr): clear tslint warning (#15)

maxisam · web-flow · commit ab8d41db1ac7 · 2024-10-09T12:42:19.000-05:00
diff --git a/apps/ssr-isr/server.ts b/apps/ssr-isr/server.ts
@@ -41,6 +41,7 @@ export function app(): express.Express {
     modifyGeneratedHtml: customModifyGeneratedHtml,
     compressHtml: compressHtml, // compress the html before storing in cache
     logger: new customLogger(),
+    renderingTimeoutMs: 5000, // 5 seconds timeout for rendering
     // cacheHtmlCompressionMethod: 'gzip', // compression method for cache
     // cache: fsCacheHandler,
   });
diff --git a/libs/isr/models/src/isr-handler-config.ts b/libs/isr/models/src/isr-handler-config.ts
@@ -159,7 +159,7 @@ export interface ISRHandlerConfig {
    * If the rendering takes longer than this timeout, the rendering will be stopped and an error will be thrown.
    * This is useful to prevent the server from hanging on a request that takes too long to render.
    **/
-  renderingTimeoutMs: number | undefined;
+  renderingTimeoutMs?: number | undefined;
 }
 
 export interface ServeFromCacheConfig {
diff --git a/libs/isr/server/src/utils/render-url.spec.ts b/libs/isr/server/src/utils/render-url.spec.ts
@@ -1,5 +1,6 @@
 import { CommonEngine } from '@angular/ssr';
 import { Request, Response } from 'express';
+import { ILogger } from '../../../models/src/logger';
 import { renderUrl, RenderUrlConfig } from './render-url';
 
 jest.useFakeTimers();
@@ -8,7 +9,7 @@ describe('renderUrl - Timeout Test', () => {
   let mockRequest: Request;
   let mockResponse: Response;
   let mockCommonEngine: CommonEngine;
-  let mockLogger: any;
+  let mockLogger: ILogger;
 
   beforeEach(() => {
     mockRequest = {
@@ -35,6 +36,8 @@ describe('renderUrl - Timeout Test', () => {
     mockLogger = {
       debug: jest.fn(),
       error: jest.fn(),
+      info: jest.fn(),
+      warn: jest.fn(),
     };
   });
 
diff --git a/libs/isr/server/src/utils/render-url.ts b/libs/isr/server/src/utils/render-url.ts
@@ -83,7 +83,7 @@ export const renderUrl = async (options: RenderUrlConfig): Promise<string> => {
           logger?.debug(
             `done rendering url with common engine: ${html.substring(0, 200)}...`,
           );
-          resolve(html as string);
+          resolve(html);
         })
         .catch((err) => {
           logger?.error('Error: rendering url with common engine', err);

Original file line number	Diff line number	Diff line change
`@@ -159,7 +159,7 @@ export interface ISRHandlerConfig {`
`159`	`159`	`* If the rendering takes longer than this timeout, the rendering will be stopped and an error will be thrown.`
`160`	`160`	`* This is useful to prevent the server from hanging on a request that takes too long to render.`
`161`	`161`	`**/`
`162`		`- renderingTimeoutMs: number \| undefined;`
	`162`	`+ renderingTimeoutMs?: number \| undefined;`
`163`	`163`	`}`
`164`	`164`
`165`	`165`	`export interface ServeFromCacheConfig {`