Merge pull request bootstrap-vue#1498 from larionov/dev

mosinve · web-flow · commit f32e4caf554b · 2017-12-28T19:07:25.000+07:00
fix(dropdown): fixed aria-labbeledby for non-split dropdowns
diff --git a/src/components/dropdown/dropdown.js b/src/components/dropdown/dropdown.js
@@ -62,7 +62,7 @@ export default {
         class: t.menuClasses,
         attrs: {
           role: t.role,
-          'aria-labelledby': t.safeId(split ? '_BV_toggle_' : '_BV_button_')
+          'aria-labelledby': t.safeId(this.split ? '_BV_toggle_' : '_BV_button_')
         },
         on: {
           mouseover: t.onMouseOver,
diff --git a/src/components/dropdown/dropdown.spec.js b/src/components/dropdown/dropdown.spec.js
@@ -107,4 +107,14 @@ describe('dropdown', async () => {
 
     expect(Array.from(dd_6.$refs.menu.children).filter(node => node.classList.contains('dropdown-divider')).length).toBe(1)
   })
+
+  it('.dropdown menu aria-labelledby should target `_BV_button_` when not in split mode', async () => {
+    const { app: { $refs } } = window
+    const { dd_1 } = $refs // eslint-disable-line camelcase
+
+    const menu = Array.from(dd_1.$el.children)
+      .find(node => node.attributes.role && node.attributes.role.value === 'menu')
+
+    expect(menu.attributes['aria-labelledby'].value).toMatch(/_BV_button_$/)
+  })
 })
