feat: make TimeoutError extend builtins.TimeoutError (microsoft#2297)

danphenderson · web-flow · commit 8cd06e5190d8 · 2024-02-14T10:44:05.000+01:00
diff --git a/.gitignore b/.gitignore
@@ -18,3 +18,5 @@ coverage.xml
 junit/
 htmldocs/
 utils/docker/dist/
+.venv/
+Pipfile*
diff --git a/playwright/_impl/_errors.py b/playwright/_impl/_errors.py
@@ -16,6 +16,7 @@
 # stable API.
 
 
+from builtins import TimeoutError as TimeoutErrorBuiltin
 from typing import Optional
 
 
@@ -43,7 +44,7 @@ def stack(self) -> Optional[str]:
         return self._stack
 
 
-class TimeoutError(Error):
+class TimeoutError(Error, TimeoutErrorBuiltin):
     pass
 
 
diff --git a/tests/async/test_click.py b/tests/async/test_click.py
@@ -13,6 +13,7 @@
 # limitations under the License.
 
 import asyncio
+import builtins
 from typing import Optional
 
 import pytest
@@ -638,6 +639,9 @@ async def test_timeout_waiting_for_hit_target(page: Page, server: Server) -> Non
     assert "Timeout 5000ms exceeded." in error.message
     assert '<div id="blocker"></div> intercepts pointer events' in error.message
     assert "retrying click action" in error.message
+    assert isinstance(error, Error)
+    assert isinstance(error, TimeoutError)
+    assert isinstance(error, builtins.TimeoutError)
 
 
 async def test_fail_when_obscured_and_not_waiting_for_hit_target(
