py/binary: Remove mp_binary_set_val_array_from_int().

projectgus · projectgus · commit 7691da3b2ff2 · 2025-07-23T11:19:44.000+10:00
This is a long-standing C function in binary.h, but it's no longer called
from inside MicroPython.

This work was funded through GitHub Sponsors.

Signed-off-by: Angus Gratton &lt;angus@redyak.com.au&gt;
diff --git a/ports/unix/coverage.c b/ports/unix/coverage.c
@@ -627,19 +627,6 @@ static mp_obj_t extra_coverage(void) {
         mp_printf(&mp_plat_print, "%s\n", buf2);
     }
 
-    // binary
-    {
-        mp_printf(&mp_plat_print, "# binary\n");
-
-        // call function with float and double typecodes
-        float far[1];
-        double dar[1];
-        mp_binary_set_val_array_from_int('f', far, 0, 123);
-        mp_printf(&mp_plat_print, "%.0f\n", (double)far[0]);
-        mp_binary_set_val_array_from_int('d', dar, 0, 456);
-        mp_printf(&mp_plat_print, "%.0lf\n", dar[0]);
-    }
-
     // VM
     {
         mp_printf(&mp_plat_print, "# VM\n");
diff --git a/py/binary.c b/py/binary.c
@@ -491,53 +491,3 @@ void mp_binary_set_val_array(char typecode, void *p, size_t index, mp_obj_t val_
         }
     }
 }
-
-void mp_binary_set_val_array_from_int(char typecode, void *p, size_t index, mp_int_t val) {
-    switch (typecode) {
-        case 'b':
-            ((signed char *)p)[index] = val;
-            break;
-        case BYTEARRAY_TYPECODE:
-        case 'B':
-            ((unsigned char *)p)[index] = val;
-            break;
-        case 'h':
-            ((short *)p)[index] = val;
-            break;
-        case 'H':
-            ((unsigned short *)p)[index] = val;
-            break;
-        case 'i':
-            ((int *)p)[index] = val;
-            break;
-        case 'I':
-            ((unsigned int *)p)[index] = val;
-            break;
-        case 'l':
-            ((long *)p)[index] = val;
-            break;
-        case 'L':
-            ((unsigned long *)p)[index] = val;
-            break;
-        #if MICROPY_LONGINT_IMPL != MICROPY_LONGINT_IMPL_NONE
-        case 'q':
-            ((long long *)p)[index] = val;
-            break;
-        case 'Q':
-            ((unsigned long long *)p)[index] = val;
-            break;
-        #endif
-        #if MICROPY_PY_BUILTINS_FLOAT
-        case 'f':
-            ((float *)p)[index] = (float)val;
-            break;
-        case 'd':
-            ((double *)p)[index] = (double)val;
-            break;
-        #endif
-        // Extension to CPython: array of pointers
-        case 'P':
-            ((void **)p)[index] = (void *)(uintptr_t)val;
-            break;
-    }
-}
diff --git a/py/binary.h b/py/binary.h
@@ -37,7 +37,6 @@
 size_t mp_binary_get_size(char struct_type, char val_type, size_t *palign);
 mp_obj_t mp_binary_get_val_array(char typecode, void *p, size_t index);
 void mp_binary_set_val_array(char typecode, void *p, size_t index, mp_obj_t val_in);
-void mp_binary_set_val_array_from_int(char typecode, void *p, size_t index, mp_int_t val);
 mp_obj_t mp_binary_get_val(char struct_type, char val_type, byte *p_base, byte **ptr);
 void mp_binary_set_val(char struct_type, char val_type, mp_obj_t val_in, byte *p_base, byte **ptr);
 long long mp_binary_get_int(size_t size, bool is_signed, bool big_endian, const byte *src);
