Skip to content

Commit ede1f75

Browse files
committed
tests/run-perfbench.py: Change -p/-d arguments to -t.
The existing "-t" option is changed to "-m". Signed-off-by: Damien George <damien@micropython.org>
1 parent 2636245 commit ede1f75

File tree

1 file changed

+17
-18
lines changed

1 file changed

+17
-18
lines changed

tests/run-perfbench.py

Lines changed: 17 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,6 @@
1212

1313
run_tests_module = __import__("run-tests")
1414

15-
sys.path.append("../tools")
16-
import pyboard
17-
1815
prepare_script_for_target = run_tests_module.prepare_script_for_target
1916

2017
# Paths for host executables
@@ -47,12 +44,12 @@ def run_script_on_target(target, script):
4744
output = b""
4845
err = None
4946

50-
if isinstance(target, pyboard.Pyboard):
47+
if hasattr(target, "enter_raw_repl"):
5148
# Run via pyboard interface
5249
try:
5350
target.enter_raw_repl()
5451
output = target.exec_(script)
55-
except pyboard.PyboardError as er:
52+
except run_tests_module.pyboard.PyboardError as er:
5653
err = er
5754
else:
5855
# Run local executable
@@ -125,7 +122,7 @@ def run_benchmarks(args, target, param_n, param_m, n_average, test_list):
125122
f.write(test_script)
126123

127124
# Process script through mpy-cross if needed
128-
if isinstance(target, pyboard.Pyboard) or args.via_mpy:
125+
if hasattr(target, "enter_raw_repl") or args.via_mpy:
129126
crash, test_script_target = prepare_script_for_target(args, script_text=test_script)
130127
if crash:
131128
test_results.append((test_file, "fail", "preparation"))
@@ -253,17 +250,17 @@ def compute_diff(file1, file2, diff_score):
253250
def main():
254251
cmd_parser = argparse.ArgumentParser(description="Run benchmarks for MicroPython")
255252
cmd_parser.add_argument(
256-
"-t", "--diff-time", action="store_true", help="diff time outputs from a previous run"
253+
"-m", "--diff-time", action="store_true", help="diff time outputs from a previous run"
257254
)
258255
cmd_parser.add_argument(
259256
"-s", "--diff-score", action="store_true", help="diff score outputs from a previous run"
260257
)
261258
cmd_parser.add_argument(
262-
"-p", "--pyboard", action="store_true", help="run tests via pyboard.py"
263-
)
264-
cmd_parser.add_argument(
265-
"-d", "--device", default="/dev/ttyACM0", help="the device for pyboard.py"
259+
"-t", "--test-instance", default="unix", help="the MicroPython instance to test"
266260
)
261+
cmd_parser.add_argument("--baudrate", default=115200, help="baud rate of the serial device")
262+
cmd_parser.add_argument("--user", default="micro", help="telnet login username")
263+
cmd_parser.add_argument("--password", default="python", help="telnet login password")
267264
cmd_parser.add_argument("-a", "--average", default="8", help="averaging number")
268265
cmd_parser.add_argument(
269266
"--emit", default="bytecode", help="MicroPython emitter to use (bytecode or native)"
@@ -295,15 +292,17 @@ def main():
295292
M = int(args.M[0])
296293
n_average = int(args.average)
297294

298-
if args.pyboard:
299-
if not args.mpy_cross_flags:
300-
args.mpy_cross_flags = "-march=armv7m"
301-
target = pyboard.Pyboard(args.device)
302-
target.enter_raw_repl()
303-
else:
295+
target = run_tests_module.get_test_instance(
296+
args.test_instance, args.baudrate, args.user, args.password
297+
)
298+
if target is None:
299+
# Use the unix port of MicroPython.
304300
target = [MICROPYTHON, "-X", "emit=" + args.emit]
305301
if args.heapsize is not None:
306302
target.extend(["-X", "heapsize=" + args.heapsize])
303+
else:
304+
if not args.mpy_cross_flags:
305+
args.mpy_cross_flags = "-march=armv7m"
307306

308307
if len(args.files) == 0:
309308
tests_skip = ("benchrun.py",)
@@ -324,7 +323,7 @@ def main():
324323
test_results = run_benchmarks(args, target, N, M, n_average, tests)
325324
res = run_tests_module.create_test_report(args, test_results)
326325

327-
if isinstance(target, pyboard.Pyboard):
326+
if hasattr(target, "exit_raw_repl"):
328327
target.exit_raw_repl()
329328
target.close()
330329

0 commit comments

Comments
 (0)