cpydiff: Document complex() parsing difference. #17470
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #17470 +/- ##
=======================================
Coverage 98.54% 98.55%
=======================================
Files 169 169
Lines 21941 21946 +5
=======================================
+ Hits 21621 21628 +7
+ Misses 320 318 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
235b774 to
9527fa0
Compare
dpgeorge
reviewed
Jun 16, 2025
In micropython#17384 it was decided that fixing this difference was not worth the code size increase. Signed-off-by: Jeff Epler <jepler@gmail.com>
9527fa0 to
f4ac63e
Compare
dpgeorge
approved these changes
Jun 16, 2025
|
Rebased and merged in 5901b8d |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In #17384 it was decided that fixing this difference was not worth the code size increase.
Testing
Built & viewed the documentation locally
