feat(common): Changed public members on OptimizelyUserContext to be virtual

daniel-pons · daniel-pons · commit e0a1a41e1187 · 2021-09-08T13:56:26.000+02:00
Make OptimizelyUserContext members virtual, making them overridable by testing frameworks
diff --git a/OptimizelySDK/OptimizelyUserContext.cs b/OptimizelySDK/OptimizelyUserContext.cs
@@ -52,7 +52,7 @@ public OptimizelyUserContext(Optimizely optimizely, string userId, UserAttribute
         /// Returns Optimizely instance associated with the UserContext.
         /// </summary>
         /// <returns> Optimizely instance.</returns>
-        public Optimizely GetOptimizely()
+        public virtual Optimizely GetOptimizely()
         {
             return Optimizely;
         }
@@ -61,7 +61,7 @@ public Optimizely GetOptimizely()
         /// Returns UserId associated with the UserContext
         /// </summary>
         /// <returns>UserId of this instance.</returns>
-        public string GetUserId()
+        public virtual string GetUserId()
         {
             return UserId;
         }
@@ -108,7 +108,7 @@ public void SetAttribute(string key, object value)
         /// </summary>
         /// <param name="key">A flag key for which a decision will be made.</param>
         /// <returns>A decision result.</returns>
-        public OptimizelyDecision Decide(string key)
+        public virtual OptimizelyDecision Decide(string key)
         {
             return Decide(key, new OptimizelyDecideOption[] { });
         }
@@ -122,7 +122,7 @@ public OptimizelyDecision Decide(string key)
         /// <param name="key">A flag key for which a decision will be made.</param>
         /// <param name="options">A list of options for decision-making.</param>
         /// <returns>A decision result.</returns>
-        public OptimizelyDecision Decide(string key,
+        public virtual OptimizelyDecision Decide(string key,
             OptimizelyDecideOption[] options)
         {
             var optimizelyUserContext = Copy();
@@ -134,7 +134,7 @@ public OptimizelyDecision Decide(string key,
         /// </summary>
         /// <param name="keys">list of flag keys for which a decision will be made.</param>
         /// <returns>A dictionary of all decision results, mapped by flag keys.</returns>
-        public Dictionary<string, OptimizelyDecision> DecideForKeys(string[] keys, OptimizelyDecideOption[] options)
+        public virtual Dictionary<string, OptimizelyDecision> DecideForKeys(string[] keys, OptimizelyDecideOption[] options)
         {
             var optimizelyUserContext = Copy();
             return Optimizely.DecideForKeys(optimizelyUserContext, keys, options);
@@ -145,7 +145,7 @@ public Dictionary<string, OptimizelyDecision> DecideForKeys(string[] keys, Optim
         /// </summary>
         /// <param name="keys">list of flag keys for which a decision will be made.</param>
         /// <returns>A dictionary of all decision results, mapped by flag keys.</returns>
-        public Dictionary<string, OptimizelyDecision> DecideForKeys(string[] keys)
+        public virtual Dictionary<string, OptimizelyDecision> DecideForKeys(string[] keys)
         {
             return DecideForKeys(keys, new OptimizelyDecideOption[] { });
         }
@@ -154,7 +154,7 @@ public Dictionary<string, OptimizelyDecision> DecideForKeys(string[] keys)
         /// Returns a key-map of decision results ({@link OptimizelyDecision}) for all active flag keys.
         /// </summary>
         /// <returns>A dictionary of all decision results, mapped by flag keys.</returns>
-        public Dictionary<string, OptimizelyDecision> DecideAll()
+        public virtual Dictionary<string, OptimizelyDecision> DecideAll()
         {
             return DecideAll(new OptimizelyDecideOption[] { });
         }
@@ -164,7 +164,7 @@ public Dictionary<string, OptimizelyDecision> DecideAll()
         /// </summary>
         /// <param name="options">A list of options for decision-making.</param>
         /// <returns>All decision results mapped by flag keys.</returns>
-        public Dictionary<string, OptimizelyDecision> DecideAll(OptimizelyDecideOption[] options)
+        public virtual Dictionary<string, OptimizelyDecision> DecideAll(OptimizelyDecideOption[] options)
         {
             var optimizelyUserContext = Copy();
             return Optimizely.DecideAll(optimizelyUserContext, options);
@@ -174,7 +174,7 @@ public Dictionary<string, OptimizelyDecision> DecideAll(OptimizelyDecideOption[]
         /// Track an event.
         /// </summary>
         /// <param name="eventName">The event name.</param>
-        public void TrackEvent(string eventName)
+        public virtual void TrackEvent(string eventName)
         {
             TrackEvent(eventName, new EventTags());
         }
@@ -184,7 +184,7 @@ public void TrackEvent(string eventName)
         /// </summary>
         /// <param name="eventName">The event name.</param>
         /// <param name="eventTags">A map of event tag names to event tag values.</param>
-        public void TrackEvent(string eventName, 
+        public virtual void TrackEvent(string eventName, 
             EventTags eventTags)
         {
             Optimizely.Track(eventName, UserId, Attributes, eventTags);

Original file line number	Diff line number	Diff line change
`@@ -52,7 +52,7 @@ public OptimizelyUserContext(Optimizely optimizely, string userId, UserAttribute`
`52`	`52`	`/// Returns Optimizely instance associated with the UserContext.`
`53`	`53`	`/// </summary>`
`54`	`54`	`/// <returns> Optimizely instance.</returns>`
`55`		`- public Optimizely GetOptimizely()`
	`55`	`+ public virtual Optimizely GetOptimizely()`
`56`	`56`	`{`
`57`	`57`	`return Optimizely;`
`58`	`58`	`}`
`@@ -61,7 +61,7 @@ public Optimizely GetOptimizely()`
`61`	`61`	`/// Returns UserId associated with the UserContext`
`62`	`62`	`/// </summary>`
`63`	`63`	`/// <returns>UserId of this instance.</returns>`
`64`		`- public string GetUserId()`
	`64`	`+ public virtual string GetUserId()`
`65`	`65`	`{`
`66`	`66`	`return UserId;`
`67`	`67`	`}`
`@@ -108,7 +108,7 @@ public void SetAttribute(string key, object value)`
`108`	`108`	`/// </summary>`
`109`	`109`	`/// <param name="key">A flag key for which a decision will be made.</param>`
`110`	`110`	`/// <returns>A decision result.</returns>`
`111`		`- public OptimizelyDecision Decide(string key)`
	`111`	`+ public virtual OptimizelyDecision Decide(string key)`
`112`	`112`	`{`
`113`	`113`	`return Decide(key, new OptimizelyDecideOption[] { });`
`114`	`114`	`}`
`@@ -122,7 +122,7 @@ public OptimizelyDecision Decide(string key)`
`122`	`122`	`/// <param name="key">A flag key for which a decision will be made.</param>`
`123`	`123`	`/// <param name="options">A list of options for decision-making.</param>`
`124`	`124`	`/// <returns>A decision result.</returns>`
`125`		`- public OptimizelyDecision Decide(string key,`
	`125`	`+ public virtual OptimizelyDecision Decide(string key,`
`126`	`126`	`OptimizelyDecideOption[] options)`
`127`	`127`	`{`
`128`	`128`	`var optimizelyUserContext = Copy();`
`@@ -134,7 +134,7 @@ public OptimizelyDecision Decide(string key,`
`134`	`134`	`/// </summary>`
`135`	`135`	`/// <param name="keys">list of flag keys for which a decision will be made.</param>`
`136`	`136`	`/// <returns>A dictionary of all decision results, mapped by flag keys.</returns>`
`137`		`- public Dictionary<string, OptimizelyDecision> DecideForKeys(string[] keys, OptimizelyDecideOption[] options)`
	`137`	`+ public virtual Dictionary<string, OptimizelyDecision> DecideForKeys(string[] keys, OptimizelyDecideOption[] options)`
`138`	`138`	`{`
`139`	`139`	`var optimizelyUserContext = Copy();`
`140`	`140`	`return Optimizely.DecideForKeys(optimizelyUserContext, keys, options);`
`@@ -145,7 +145,7 @@ public Dictionary<string, OptimizelyDecision> DecideForKeys(string[] keys, Optim`
`145`	`145`	`/// </summary>`
`146`	`146`	`/// <param name="keys">list of flag keys for which a decision will be made.</param>`
`147`	`147`	`/// <returns>A dictionary of all decision results, mapped by flag keys.</returns>`
`148`		`- public Dictionary<string, OptimizelyDecision> DecideForKeys(string[] keys)`
	`148`	`+ public virtual Dictionary<string, OptimizelyDecision> DecideForKeys(string[] keys)`
`149`	`149`	`{`
`150`	`150`	`return DecideForKeys(keys, new OptimizelyDecideOption[] { });`
`151`	`151`	`}`
`@@ -154,7 +154,7 @@ public Dictionary<string, OptimizelyDecision> DecideForKeys(string[] keys)`
`154`	`154`	`/// Returns a key-map of decision results ({@link OptimizelyDecision}) for all active flag keys.`
`155`	`155`	`/// </summary>`
`156`	`156`	`/// <returns>A dictionary of all decision results, mapped by flag keys.</returns>`
`157`		`- public Dictionary<string, OptimizelyDecision> DecideAll()`
	`157`	`+ public virtual Dictionary<string, OptimizelyDecision> DecideAll()`
`158`	`158`	`{`
`159`	`159`	`return DecideAll(new OptimizelyDecideOption[] { });`
`160`	`160`	`}`
`@@ -164,7 +164,7 @@ public Dictionary<string, OptimizelyDecision> DecideAll()`
`164`	`164`	`/// </summary>`
`165`	`165`	`/// <param name="options">A list of options for decision-making.</param>`
`166`	`166`	`/// <returns>All decision results mapped by flag keys.</returns>`
`167`		`- public Dictionary<string, OptimizelyDecision> DecideAll(OptimizelyDecideOption[] options)`
	`167`	`+ public virtual Dictionary<string, OptimizelyDecision> DecideAll(OptimizelyDecideOption[] options)`
`168`	`168`	`{`
`169`	`169`	`var optimizelyUserContext = Copy();`
`170`	`170`	`return Optimizely.DecideAll(optimizelyUserContext, options);`
`@@ -174,7 +174,7 @@ public Dictionary<string, OptimizelyDecision> DecideAll(OptimizelyDecideOption[]`
`174`	`174`	`/// Track an event.`
`175`	`175`	`/// </summary>`
`176`	`176`	`/// <param name="eventName">The event name.</param>`
`177`		`- public void TrackEvent(string eventName)`
	`177`	`+ public virtual void TrackEvent(string eventName)`
`178`	`178`	`{`
`179`	`179`	`TrackEvent(eventName, new EventTags());`
`180`	`180`	`}`
`@@ -184,7 +184,7 @@ public void TrackEvent(string eventName)`
`184`	`184`	`/// </summary>`
`185`	`185`	`/// <param name="eventName">The event name.</param>`
`186`	`186`	`/// <param name="eventTags">A map of event tag names to event tag values.</param>`
`187`		`- public void TrackEvent(string eventName,`
	`187`	`+ public virtual void TrackEvent(string eventName,`
`188`	`188`	`EventTags eventTags)`
`189`	`189`	`{`
`190`	`190`	`Optimizely.Track(eventName, UserId, Attributes, eventTags);`