remove rescue Exception.

thomaszurkan-optimizely · thomaszurkan-optimizely · commit 7d457b3979ae · 2019-12-09T14:53:56.000-08:00
diff --git a/.rubocop.yml b/.rubocop.yml
@@ -46,7 +46,7 @@ Style/SignalException:
   Enabled: false
 
 Lint/RescueException:
-  Enabled: false
+  Enabled: true
 
 Layout/EndOfLine:
   EnforcedStyle: lf
diff --git a/lib/optimizely/event/batch_event_processor.rb b/lib/optimizely/event/batch_event_processor.rb
@@ -90,8 +90,8 @@ def process(user_event)
 
       begin
         @event_queue.push(user_event, true)
-      rescue Exception
-        @logger.log(Logger::WARN, 'Payload not accepted by the queue.')
+      rescue => e
+        @logger.log(Logger::WARN, 'Payload not accepted by the queue. ' + e.message)
         return
       end
     end
diff --git a/spec/event/batch_event_processor_spec.rb b/spec/event/batch_event_processor_spec.rb
@@ -62,7 +62,7 @@
 
     @event_processor.process(conversion_event)
     # flush interval is set to 100ms. Wait for 300ms and assert that event is dispatched.
-    sleep 1
+    sleep 100
 
     expect(@event_dispatcher).to have_received(:dispatch_event).with(log_event).once
     expect(@notification_center).to have_received(:send_notifications).with(
