Fixing building and publishing

andrefarzat · andrefarzat · commit 2b18223b39d5 · 2019-01-12T15:07:53.000-02:00
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -34,6 +34,8 @@ jobs:
             - node_modules
           key: v1-dependencies-{{ checksum "package.json" }}
 
+      - run: npm run build -- --prod
+
       # run tests!
       - run: npm run lint
       - run: npm run test -- --watch=false --code-coverage
diff --git a/bin/build b/bin/build
@@ -7,7 +7,7 @@ then
     exit 1;
 fi
 
-npm run build
+npm run build:publish
 
 mv ./angular-plotly.js.metadata.json dist
 cp ./README.md dist
diff --git a/package.json b/package.json
@@ -6,7 +6,8 @@
   "scripts": {
     "ng": "ng",
     "start": "ng serve",
-    "build": "ng-packagr -p ng-package.json",
+    "build": "ng build",
+    "build:publish": "ng-packagr -p ng-package.json",
     "lint": "ng lint",
     "test": "ng test",
     "postversion": "git push && git push --tags"
diff --git a/src/app/plotly-via-cdn/plotly-via-cdn.module.ts b/src/app/plotly-via-cdn/plotly-via-cdn.module.ts
@@ -11,7 +11,7 @@ import { SharedModule } from '../shared/shared.module';
     exports: [PlotComponent]
 })
 export class PlotlyViaCDNModule {
-    static plotlyVersion?: string;
+    static plotlyVersion?: string = 'latest';
 
     static setPlotlyVersion(version: string) {
         const isOk = version === 'latest' || /^\d\.\d{1,2}\.\d{1,2}$/.test(version);
diff --git a/src/app/shared/plotly.service.ts b/src/app/shared/plotly.service.ts
@@ -7,7 +7,7 @@ import { Plotly } from './plotly.interface';
 })
 export class PlotlyService {
     protected static instances: Plotly.PlotlyHTMLElement[] = [];
-    protected static _plotly?: any;
+    protected static _plotly?: any = undefined;
 
     public static setPlotly(plotly: any) {
         PlotlyService._plotly = plotly;
