From fa696e481878cec1006e5b9e44672f7e6013c414 Mon Sep 17 00:00:00 2001
From: Anna Henningsen <anna@addaleax.net>
Date: Thu, 12 Dec 2024 10:38:45 -0500
Subject: [PATCH] fix: address `-Wpessimizing-move` warning in binary blob
 helpers

Fixes:

    ../src/node_main.cc:945:52: warning: moving a temporary object prevents copy elision
        std::vector<char>* str = new std::vector<char>(std::move(GetBoxednodeCodeCacheVector()));
                                                      ^
    ../src/node_main.cc:945:52: note: remove std::move call here
        std::vector<char>* str = new std::vector<char>(std::move(GetBoxednodeCodeCacheVector()));
                                                      ^~~~~~~~~~                             ~
    ../src/node_main.cc:986:52: warning: moving a temporary object prevents copy elision
        std::vector<char>* str = new std::vector<char>(std::move(GetBoxednodeSnapshotBlobVector()));
                                                      ^
    ../src/node_main.cc:986:52: note: remove std::move call here
        std::vector<char>* str = new std::vector<char>(std::move(GetBoxednodeSnapshotBlobVector()));
---
 src/helpers.ts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/helpers.ts b/src/helpers.ts
index 2b14801..e559466 100644
--- a/src/helpers.ts
+++ b/src/helpers.ts
@@ -179,7 +179,7 @@ export async function createCompressedBlobDefinition (fnName: string, source: Ui
 function blobTypedArrayAccessors (fnName: string, sourceLength: number): string {
   return `
   std::shared_ptr<v8::BackingStore> ${fnName}BackingStore() {
-    std::vector<char>* str = new std::vector<char>(std::move(${fnName}Vector()));
+    std::vector<char>* str = new std::vector<char>(${fnName}Vector());
     return v8::SharedArrayBuffer::NewBackingStore(
       &str->front(),
       str->size(),