Merge pull request #16 from mongodb-js/close-database-bug

rueckstiess · rueckstiess · commit ffc2ba10ba0c · 2015-11-21T14:42:28.000+11:00
INT-817 don't close the db afterwards
diff --git a/lib/fetch.js b/lib/fetch.js
@@ -441,7 +441,6 @@ function getInstanceDetail(db, done) {
       return done(err);
     }
     // cleanup
-    results.db.close();
     results = _.omit(results, ['db', 'listDatabases', 'allowedDatabases',
       'userInfo', 'listCollections', 'allowedCollections']);
     return done(null, results);
diff --git a/test/fetch.test.js b/test/fetch.test.js
@@ -82,6 +82,20 @@ describe('mongodb-instance-model#fetch', function() {
         done();
       });
     });
+    it('should not close the db after getting instance details', function(done) {
+      assert(db);
+      fetch(db, function(err) {
+        if (err) {
+          return done(err);
+        }
+        db.admin().ping(function(_err, pingResult) {
+          if (_err) {
+            done(_err);
+          }
+          done(null, pingResult);
+        });
+      });
+    });
   });
 
   /**

Original file line number	Diff line number	Diff line change
`@@ -441,7 +441,6 @@ function getInstanceDetail(db, done) {`
`441`	`441`	`return done(err);`
`442`	`442`	`}`
`443`	`443`	`// cleanup`
`444`		`- results.db.close();`
`445`	`444`	`results = _.omit(results, ['db', 'listDatabases', 'allowedDatabases',`
`446`	`445`	`'userInfo', 'listCollections', 'allowedCollections']);`
`447`	`446`	`return done(null, results);`