Make AuthenticationPacket properties public

felixge · felixge · commit 97ef16f9a8ec · 2011-12-30T16:28:43.000+01:00
This is more like a bag of data than anything else.
diff --git a/lib/protocol/packets/client/AuthenticationPacket.js b/lib/protocol/packets/client/AuthenticationPacket.js
@@ -1,37 +1,40 @@
+var _              = require('underscore');
 var Auth           = require('../../../Auth');
 var OutgoingPacket = require('../../../OutgoingPacket');
 
 // Client_Authentication_Packet (MySql >= 4.1)
 // http://forge.mysql.com/wiki/MySQL_Internals_ClientServer_Protocol#Client_Authentication_Packet
 module.exports = AuthenticationPacket;
 function AuthenticationPacket(properties) {
-  this._number         = properties.number;
-  this._scrambleBuffer = properties.scrambleBuffer;
-  this._password       = properties.password;
-  this._user           = properties.user;
-  this._database       = properties.database;
-  this._flags          = properties.flags;
-  this._maxPacketSize  = properties.maxPacketSize;
-  this._charsetNumber  = properties.charsetNumber;
+  this.number         = null;
+  this.scrambleBuffer = null;
+  this.password       = null;
+  this.user           = null;
+  this.database       = null;
+  this.flags          = null;
+  this.maxPacketSize  = null;
+  this.charsetNumber  = null;
+
+  _.extend(this, properties);
 }
 
 AuthenticationPacket.prototype.toBuffer = function() {
-  var token = Auth.token(this._password, this._scrambleBuffer);
+  var token = Auth.token(this.password, this.scrambleBuffer);
   var packetSize = (
     4 + 4 + 1 + 23 +
-    this._user.length + 1 +
+    this.user.length + 1 +
     token.length + 1 +
-    this._database.length + 1
+    this.database.length + 1
   );
-  var packet = new OutgoingPacket(packetSize, this._number);
+  var packet = new OutgoingPacket(packetSize, this.number);
 
-  packet.writeNumber(4, this._flags);
-  packet.writeNumber(4, this._maxPacketSize);
-  packet.writeNumber(1, this._charsetNumber);
+  packet.writeNumber(4, this.flags);
+  packet.writeNumber(4, this.maxPacketSize);
+  packet.writeNumber(1, this.charsetNumber);
   packet.writeFiller(23);
-  packet.writeNullTerminated(this._user);
+  packet.writeNullTerminated(this.user);
   packet.writeLengthCoded(token);
-  packet.writeNullTerminated(this._database);
+  packet.writeNullTerminated(this.database);
 
   return packet.buffer;
 };
