Adds ability to change client connection flags

dresende · dresende · commit dc04c61c2bcb · 2012-10-31T19:11:05.000Z
Example:

```js
mysql.createConnection("mysql://.../db?flags=-found_rows,plugin_auth");
```
(blacklists FOUND_ROWS, adds PLUGIN_AUTH)
diff --git a/lib/ConnectionConfig.js b/lib/ConnectionConfig.js
@@ -17,6 +17,7 @@ function ConnectionConfig(options) {
   this.insecureAuth = options.insecureAuth || false;
   this.debug        = options.debug;
   this.timezone     = options.timezone || 'local';
+  this.flags        = options.flags || '';
   this.typeCast     = (options.typeCast === undefined)
     ? true
     : options.typeCast;
@@ -32,23 +33,37 @@ function ConnectionConfig(options) {
     ? ConnectionConfig.getCharsetNumber(options.charset)
     : Charsets.UTF8_GENERAL_CI;
 
-  this.clientFlags =
-    ClientConstants.CLIENT_LONG_PASSWORD |
-    ClientConstants.CLIENT_FOUND_ROWS |
-    ClientConstants.CLIENT_LONG_FLAG |
-    ClientConstants.CLIENT_CONNECT_WITH_DB |
-    ClientConstants.CLIENT_ODBC |
-    ClientConstants.CLIENT_LOCAL_FILES |
-    ClientConstants.CLIENT_IGNORE_SPACE |
-    ClientConstants.CLIENT_PROTOCOL_41 |
-    ClientConstants.CLIENT_IGNORE_SIGPIPE |
-    ClientConstants.CLIENT_TRANSACTIONS |
-    ClientConstants.CLIENT_RESERVED |
-    ClientConstants.CLIENT_SECURE_CONNECTION |
-    ClientConstants.CLIENT_MULTI_RESULTS;
-
+  this.defaultFlags = [ "LONG_PASSWORD", "FOUND_ROWS", "LONG_FLAG",
+                        "CONNECT_WITH_DB", "ODBC", "LOCAL_FILES",
+                        "IGNORE_SPACE", "PROTOCOL_41", "IGNORE_SIGPIPE",
+                        "TRANSACTIONS", "RESERVED", "SECURE_CONNECTION",
+                        "MULTI_RESULTS" ];
   if (options.multipleStatements) {
-    this.clientFlags |= ClientConstants.CLIENT_MULTI_STATEMENTS;
+    this.defaultFlags.push("MULTI_STATEMENTS");
+  }
+
+  var i;
+
+  if (this.flags.length > 0) {
+    this.flags = this.flags.toUpperCase().split(',');
+  } else {
+    this.flags = [];
+  }
+
+  this.clientFlags = 0x0;
+
+  // add default flags unless "blacklisted"
+  for (i in this.defaultFlags) {
+    if (this.flags.indexOf("-" + this.defaultFlags[i]) >= 0) continue;
+
+    this.clientFlags |= ClientConstants["CLIENT_" + this.defaultFlags[i]] || 0x0;
+  }
+  // add user flags unless already already added
+  for (i in this.flags) {
+    if (this.flags[i][0] == "-") continue;
+    if (this.defaultFlags.indexOf(this.flags[i]) >= 0) continue;
+
+    this.clientFlags |= ClientConstants["CLIENT_" + this.flags[i]] || 0x0;
   }
 }
 
