Fixed javascript not to be in global scope.

shazron · shazron · commit 4564558ec071 · 2010-10-11T00:38:35.000-07:00
diff --git a/iPhone/AdPlugin/SAiOSAdPlugin.m b/iPhone/AdPlugin/SAiOSAdPlugin.m
@@ -150,9 +150,12 @@ - (void)bannerViewDidLoadAd:(ADBannerView *)banner
     if (adBannerViewClass)
     {
 		NSString* jsString = 
-				@"var e = document.createEvent('Events');"
-				"e.initEvent('iAdBannerViewDidLoadAdEvent');"
-				"document.dispatchEvent(e);";
+		@"(function(){"
+		"var e = document.createEvent('Events');"
+		"e.initEvent('iAdBannerViewDidLoadAdEvent');"
+		"document.dispatchEvent(e);"
+		"})();";
+
 		[super writeJavascript:jsString];
     }
 }
@@ -163,10 +166,12 @@ - (void)bannerView:(ADBannerView *)banner didFailToReceiveAdWithError:(NSError*)
     if (adBannerViewClass)
     {
 		NSString* jsString = 
-		@"var e = document.createEvent('Events');"
+		@"(function(){"
+		"var e = document.createEvent('Events');"
 		"e.initEvent('iAdBannerViewDidFailToReceiveAdWithErrorEvent');"
 		"e.error = '%@';"
-		"document.dispatchEvent(e);";
+		"document.dispatchEvent(e);"
+		"})();";
 		
 		[super writeJavascript:[NSString stringWithFormat:jsString, [error description]]];
     }

Original file line number	Diff line number	Diff line change
`@@ -150,9 +150,12 @@ - (void)bannerViewDidLoadAd:(ADBannerView *)banner`
`150`	`150`	`if (adBannerViewClass)`
`151`	`151`	`{`
`152`	`152`	`NSString* jsString =`
`153`		`- @"var e = document.createEvent('Events');"`
`154`		`- "e.initEvent('iAdBannerViewDidLoadAdEvent');"`
`155`		`- "document.dispatchEvent(e);";`
	`153`	`+ @"(function(){"`
	`154`	`+ "var e = document.createEvent('Events');"`
	`155`	`+ "e.initEvent('iAdBannerViewDidLoadAdEvent');"`
	`156`	`+ "document.dispatchEvent(e);"`
	`157`	`+ "})();";`
	`158`	`+`
`156`	`159`	`[super writeJavascript:jsString];`
`157`	`160`	`}`
`158`	`161`	`}`
`@@ -163,10 +166,12 @@ - (void)bannerView:(ADBannerView )banner didFailToReceiveAdWithError:(NSError)`
`163`	`166`	`if (adBannerViewClass)`
`164`	`167`	`{`
`165`	`168`	`NSString* jsString =`
`166`		`- @"var e = document.createEvent('Events');"`
	`169`	`+ @"(function(){"`
	`170`	`+ "var e = document.createEvent('Events');"`
`167`	`171`	`"e.initEvent('iAdBannerViewDidFailToReceiveAdWithErrorEvent');"`
`168`	`172`	`"e.error = '%@';"`
`169`		`- "document.dispatchEvent(e);";`
	`173`	`+ "document.dispatchEvent(e);"`
	`174`	`+ "})();";`
`170`	`175`
`171`	`176`	`[super writeJavascript:[NSString stringWithFormat:jsString, [error description]]];`
`172`	`177`	`}`