Update build tools and upgrade CI to node 14 (firebase#237)

jhuleatt · web-flow · commit 5371e900366a · 2021-09-07T14:13:52.000-04:00
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -13,7 +13,7 @@ jobs:
     strategy:
       matrix:
         node-version:
-          - 12.x
+          - 14.x
     steps:
       - uses: actions/checkout@v1
       - uses: actions/setup-node@v1
diff --git a/package.json b/package.json
@@ -10,11 +10,11 @@
   },
   "license": "Apache-2.0",
   "devDependencies": {
-    "@types/node": "^15.12.2",
-    "eslint": "^7.16.0",
-    "pnpm": "^6.7.4",
+    "@types/node": "^16.7.10",
+    "eslint": "^7.32.0",
+    "pnpm": "^6.14.6",
     "rimraf": "^3.0.2",
-    "ts-node": "^9.0.0",
-    "typescript": "^3.8.3"
+    "ts-node": "^10.2.1",
+    "typescript": "^4.4.2"
   }
 }
diff --git a/scripts/separate-snippets.ts b/scripts/separate-snippets.ts
@@ -171,12 +171,15 @@ function collectSnippets(filePath: string): SnippetsConfig {
   const suffixLine = lines.find((l) => !!l.match(RE_SNIPPETS_SUFFIX));
   if (suffixLine) {
     const m = suffixLine.match(RE_SNIPPETS_SUFFIX);
-    config.suffix = m[1];
+
+    if (m && m[1]) {
+      config.suffix = m[1];
+    }
   }
 
   // A temporary array holding the names of snippets we're currently within.
   // This allows for handling nested snippets.
-  let inSnippetNames = [];
+  let inSnippetNames: string[] = [];
 
   for (const line of lines) {
     const startMatch = line.match(RE_START_SNIPPET);
