Skip to content

Commit fe672d2

Browse files
sis0k0Alexander Vakrilov
sis0k0
authored and
Alexander Vakrilov
committed
refactor(renderer): use singly linked list to keep track of NgElements (NativeScript#945)
* refactor(renderer): keep internal sibling queue for views * test: update test interface * refactor(renderer): fix setting of siblings * refactor(renderer): skip invisible nodes when using insertBefore * refactor(renderer): replace doubly linked list with singly linked one * refactor(renderer): split insert/remove of views to smaller methods methods for insert/remove from: - internal view queue (NgElements) - visual tree (NgViews) * refactor(renderer): set first child to every NgElement * style: fix linting errors * refactor(renderer): stop setting templateParents to `ProxyViewContainer`s * refactor: remove unused method from view-util * chore: remove yarn.lock * refactor(renderer): fix removal from internal queue and add trace for view util * test: fix unit tests for renderer * test(e2e): add app with nativescript-appium tests for renderer * test(e2e): fix examples for iOS Content views (Pages) cannot have multiple children and throw in iOS. * Template tag fixed * Removed NgElement (NativeScript#962) * Removed NgElement * fix: TestProject does not compile * fix: subsequent *ngIf break renderer-a * chore(lint): remove unused import * refactor(view-util): extract the lookup for next visual view into method
1 parent 85efd50 commit fe672d2

File tree

102 files changed

+2138
-493
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

102 files changed

+2138
-493
lines changed

‎e2e/renderer/.gitignore

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
platforms
2+
node_modules
3+
hooks
4+
5+
app/**/*.js
6+
e2e/**/*.js
7+
test-results.xml
8+

‎e2e/renderer/app/App_Resources/Android/AndroidManifest.xml

Lines changed: 43 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,43 @@
1+
<?xml version="1.0" encoding="utf-8"?>
2+
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
3+
package="__PACKAGE__"
4+
android:versionCode="1"
5+
android:versionName="1.0">
6+
7+
<supports-screens
8+
android:smallScreens="true"
9+
android:normalScreens="true"
10+
android:largeScreens="true"
11+
android:xlargeScreens="true"/>
12+
13+
<uses-sdk
14+
android:minSdkVersion="17"
15+
android:targetSdkVersion="__APILEVEL__"/>
16+
17+
<uses-permission android:name="android.permission.READ_EXTERNAL_STORAGE"/>
18+
<uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE"/>
19+
<uses-permission android:name="android.permission.INTERNET"/>
20+
21+
<application
22+
android:name="com.tns.NativeScriptApplication"
23+
android:allowBackup="true"
24+
android:icon="@drawable/icon"
25+
android:label="@string/app_name"
26+
android:theme="@style/AppTheme">
27+
28+
<activity
29+
android:name="com.tns.NativeScriptActivity"
30+
android:label="@string/title_activity_kimera"
31+
android:configChanges="keyboardHidden|orientation|screenSize"
32+
android:theme="@style/LaunchScreenTheme">
33+
34+
<meta-data android:name="SET_THEME_ON_LAUNCH" android:resource="@style/AppTheme" />
35+
36+
<intent-filter>
37+
<action android:name="android.intent.action.MAIN" />
38+
<category android:name="android.intent.category.LAUNCHER" />
39+
</intent-filter>
40+
</activity>
41+
<activity android:name="com.tns.ErrorReportActivity"/>
42+
</application>
43+
</manifest>

‎e2e/renderer/app/App_Resources/Android/app.gradle

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,23 @@
1+
// Add your native dependencies here:
2+
3+
// Uncomment to add recyclerview-v7 dependency
4+
//dependencies {
5+
// compile 'com.android.support:recyclerview-v7:+'
6+
//}
7+
8+
android {
9+
defaultConfig {
10+
generatedDensities = []
11+
applicationId = "org.nativescript.renderer"
12+
13+
//override supported platforms
14+
// ndk {
15+
// abiFilters.clear()
16+
// abiFilters "armeabi-v7a"
17+
// }
18+
19+
}
20+
aaptOptions {
21+
additionalParameters "--no-version-vectors"
22+
}
23+
}

‎e2e/renderer/app/App_Resources/Android/drawable-hdpi/background.png

3.42 KB
Loading

‎e2e/renderer/app/App_Resources/Android/drawable-hdpi/icon.png

10.7 KB
Loading

‎e2e/renderer/app/App_Resources/Android/drawable-hdpi/logo.png

32.4 KB
Loading

‎e2e/renderer/app/App_Resources/Android/drawable-ldpi/background.png

1.31 KB
Loading

‎e2e/renderer/app/App_Resources/Android/drawable-ldpi/icon.png

6.03 KB
Loading

‎e2e/renderer/app/App_Resources/Android/drawable-ldpi/logo.png

9.95 KB
Loading

‎e2e/renderer/app/App_Resources/Android/drawable-mdpi/background.png

1.89 KB
Loading

0 commit comments

Comments
 (0)