Skip to content

Commit 6e43528

Browse files
committed
update for coderoad-cli 0.8
1 parent f1907ad commit 6e43528

File tree

11 files changed

+18
-13
lines changed

11 files changed

+18
-13
lines changed

CHANGELOG.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,11 @@
22
All notable changes to this project will be documented in this file.
33
This project adheres to [Semantic Versioning](http://semver.org/).
44

5+
# [0.11.0] - 2016-08-09
6+
- break runner calls into two steps:
7+
- load
8+
- run
9+
510
# [0.10.10] - 2016-07-30
611
- performance increase
712
- fix test run on page load

ROADMAP.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,8 @@
77
1. Video Player
88
1. Visualize html
99
1. More test runners
10-
1. Ruby
10+
1. Elixir
11+
1. Fix Python
1112
1. Java
1213
1. User Accounts
1314
1. Sync Progress

lib/modules/setup/utils/verify.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ function setupVerify(dir, packageJson) {
1212
hasPackageJson = !!packageJson;
1313
}
1414
if (hasDir && hasPackageJson) {
15-
hasTutorial = !!coderoad_cli_1.tutorials(dir);
15+
hasTutorial = !!coderoad_cli_1.tutorials({ dir: dir });
1616
}
1717
var checks = {
1818
system: {

lib/modules/tutorial/utils/config-runner.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,8 @@ function configRunner(name, runner, dir) {
2525
runnerRoot = runnerRoot.substring(0, runnerRoot.lastIndexOf(slash));
2626
var pathToMain = path_1.join(runnerRoot, runnerMain);
2727
return {
28-
load: require(pathToMain).load,
29-
run: require(pathToMain).run,
28+
load: require(pathToMain).load || { load: function () { return console.log('invalid test loader'); } },
29+
run: require(pathToMain).run || { run: function () { return console.log('invalid test runner'); } },
3030
};
3131
}
3232
Object.defineProperty(exports, "__esModule", { value: true });

lib/modules/tutorials/reducer.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ function tutorialsReducer(t, action) {
55
if (t === void 0) { t = []; }
66
switch (action.type) {
77
case types_1.TUTORIALS_FIND:
8-
var tuts = coderoad_cli_1.tutorials(action.payload.dir);
8+
var tuts = coderoad_cli_1.tutorials({ dir: action.payload.dir });
99
return tuts ? tuts : t;
1010
default:
1111
return t;

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,9 +30,9 @@
3030
},
3131
"dependencies": {
3232
"atom-plugin-command-line": "1.0.2",
33-
"coderoad-cli": "0.6.0",
33+
"coderoad-cli": "0.8.0",
3434
"core-coderoad": "0.6.2",
35-
"material-ui": "0.15.2",
35+
"material-ui": "0.15.3",
3636
"node-file-exists": "1.1.0",
3737
"react": "15.3.0",
3838
"react-dom": "15.3.0",

src/modules/setup/utils/verify.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ export default function setupVerify(
1616
hasPackageJson = !!packageJson;
1717
}
1818
if (hasDir && hasPackageJson) {
19-
hasTutorial = !!tutorials(dir);
19+
hasTutorial = !!tutorials({ dir });
2020
}
2121

2222
let checks: CR.Checks = {

src/modules/tests/actions.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ export function testLoad() {
66
return (dispatch, getState): void => {
77
const { dir, pagePosition, tutorial, taskTests } = getState();
88
const testFile = getTestName({tutorial, pagePosition});
9-
console.log('testLoad file', testFile);
109

1110
dispatch({
1211
type: TEST_LOAD, payload: {

src/modules/tutorial/utils/config-runner.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ export default function configRunner(name: string, runner: string, dir: string):
3535
let pathToMain = join(runnerRoot, runnerMain);
3636

3737
return {
38-
load: require(pathToMain).load,
39-
run: require(pathToMain).run,
38+
load: require(pathToMain).load || { load: () => console.log('invalid test loader')},
39+
run: require(pathToMain).run || { run: () => console.log('invalid test runner')},
4040
};
4141
}

src/modules/tutorials/reducer.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ export default function tutorialsReducer(
1212
/* falls through */
1313

1414
case TUTORIALS_FIND:
15-
const tuts = tutorials(action.payload.dir);
15+
const tuts = tutorials({ dir: action.payload.dir });
1616
return tuts ? tuts : t;
1717

1818
default:

src/typings/cr/cli.d.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ declare module 'coderoad-cli' {
88
dir: string, name: string
99
): boolean | Promise<boolean>;
1010

11-
export function tutorials(dir: string): Tutorial.Info[];
11+
export function tutorials({ dir: string}): Tutorial.Info[];
1212

1313
export function validatePacakgeJson(): Validation.Object;
1414
}

0 commit comments

Comments
 (0)