[IMP] estate: Added sql and python contraints for estate model

habo-odoo · habo-odoo · commit d31233f40b1b · 2024-02-23T16:33:23.000+01:00
diff --git a/estate/models/estate_property.py b/estate/models/estate_property.py
@@ -1,12 +1,13 @@
 from odoo import models, fields, api
-from odoo.exceptions import UserError
+from odoo.exceptions import UserError, ValidationError
+from odoo.tools import float_utils
 
 
 class EstateProperty(models.Model):
     _name = "estate.property"
     _description = "Real Estate module"
 
-
+    
     name = fields.Char(required=True)
     tag_ids = fields.Many2many("estate.property.tag", string="Tags")
     property_type_id = fields.Many2one("estate.property.type", string="Property Type")
@@ -55,6 +56,13 @@ class EstateProperty(models.Model):
     total_area = fields.Integer(compute="_compute_total_area")
     best_price = fields.Float(compute="_compute_best_price")
 
+    _sql_constraints = [
+        ('check_expected_price', 'CHECK(expected_price > 0)',
+         'The expected price should be strictly positive'),
+        ('check_selling_price', 'CHECK(selling_price >= 0)',
+         'The selling price should be positive')
+    ]
+
     @api.depends("living_area", "garden_area")
     def _compute_total_area(self):
         for record in self:
@@ -90,3 +98,9 @@ def cancel_action(self):
             else:
                 record.state = "canceled"
         return True
+
+    @api.constrains('selling_price', 'expected_price')
+    def _check_selling_price(self):
+        for record in self:
+            if not float_utils.float_is_zero(record.selling_price, precision_digits=5) and float_utils.float_compare(record.selling_price, record.expected_price * 0.9, precision_digits=5) < 0:
+                raise ValidationError("The selling price cannot be lower than 90% of the expected price")
diff --git a/estate/models/estate_property_offer.py b/estate/models/estate_property_offer.py
@@ -22,6 +22,11 @@ class EstatePropertyOffer(models.Model):
     validity = fields.Integer(default=7)
     date_deadline = fields.Date(compute="_compute_date_deadline", inverse="_inverse_date_deadline")
 
+    _sql_constraints = [
+        ('check_offer_price', 'CHECK(price > 0)',
+         'The offer price should be strictly positive')
+    ]
+
     @api.depends("create_date", "validity")
     def _compute_date_deadline(self):
         for record in self:
diff --git a/estate/models/estate_property_tag.py b/estate/models/estate_property_tag.py
@@ -7,3 +7,8 @@ class EstatePropertyTag(models.Model):
 
 
     name = fields.Char(required=True)
+
+    _sql_constraints = [
+        ('unique_name', 'UNIQUE(name)',
+         'Tag name should be unique')
+    ]
diff --git a/estate/models/estate_property_type.py b/estate/models/estate_property_type.py
@@ -7,3 +7,8 @@ class EstatePropertyType(models.Model):
 
 
     name = fields.Char(required=True)
+
+    _sql_constraints = [
+        ('unique_name', 'UNIQUE(name)',
+         'Type name should be unique')
+    ]
