Move mutable callback_data to assignment later in record_meeting

ashish-spext · ashish-spext · commit efcd7a4b736f · 2025-07-10T16:17:20.000+05:30
diff --git a/videodb/client.py b/videodb/client.py
@@ -304,7 +304,7 @@ def record_meeting(
         bot_image_url: str = None,
         meeting_title: str = None,
         callback_url: str = None,
-        callback_data: dict = {},
+        callback_data: Optional[dict] = None,
         time_zone: str = "UTC",
     ) -> Meeting:
         """Record a meeting and upload it to the default collection.
@@ -319,6 +319,8 @@ def record_meeting(
         :return: :class:`Meeting <Meeting>` object representing the recording bot
         :rtype: :class:`videodb.meeting.Meeting`
         """
+        if callback_data is None:
+            callback_data = {}
 
         response = self.post(
             path=f"{ApiPath.collection}/default/{ApiPath.meeting}/{ApiPath.record}",
diff --git a/videodb/collection.py b/videodb/collection.py
@@ -520,7 +520,7 @@ def record_meeting(
         bot_image_url: str = None,
         meeting_title: str = None,
         callback_url: str = None,
-        callback_data: dict = {},
+        callback_data: Optional[dict] = None,
         time_zone: str = "UTC",
     ) -> Meeting:
         """Record a meeting and upload it to this collection.
@@ -535,6 +535,8 @@ def record_meeting(
         :return: :class:`Meeting <Meeting>` object representing the recording bot
         :rtype: :class:`videodb.meeting.Meeting`
         """
+        if callback_data is None:
+            callback_data = {}
 
         response = self._connection.post(
             path=f"{ApiPath.collection}/{self.id}/{ApiPath.meeting}/{ApiPath.record}",
diff --git a/videodb/meeting.py b/videodb/meeting.py
@@ -4,6 +4,9 @@
     VideodbError,
 )
 
+DEFAULT_MEETING_TIMEOUT = 14400  # 4 hours
+DEFAULT_POLLING_INTERVAL = 120  # 2 minutes
+
 
 class Meeting:
     """Meeting class representing a meeting recording bot.
@@ -80,7 +83,10 @@ def is_completed(self) -> bool:
         return self.status == MeetingStatus.done
 
     def wait_for_status(
-        self, target_status: str, timeout: int = 14400, interval: int = 120
+        self,
+        target_status: str,
+        timeout: int = DEFAULT_MEETING_TIMEOUT,
+        interval: int = DEFAULT_POLLING_INTERVAL,
     ) -> bool:
         """Wait for the meeting to reach a specific status.
 
