Polishing

jhoeller · jhoeller · commit 6d6d772f31bb · 2017-07-20T00:14:56.000+02:00
diff --git a/spring-aop/src/main/java/org/springframework/aop/config/SimpleBeanFactoryAwareAspectInstanceFactory.java b/spring-aop/src/main/java/org/springframework/aop/config/SimpleBeanFactoryAwareAspectInstanceFactory.java
@@ -24,7 +24,6 @@
 import org.springframework.lang.Nullable;
 import org.springframework.util.Assert;
 import org.springframework.util.ClassUtils;
-import org.springframework.util.StringUtils;
 
 /**
  * Implementation of {@link AspectInstanceFactory} that locates the aspect from the
diff --git a/spring-jdbc/src/main/java/org/springframework/jdbc/core/simple/AbstractJdbcInsert.java b/spring-jdbc/src/main/java/org/springframework/jdbc/core/simple/AbstractJdbcInsert.java
@@ -81,12 +81,10 @@ public abstract class AbstractJdbcInsert {
 	private volatile boolean compiled = false;
 
 	/** The generated string used for insert statement */
-	@Nullable
-	private String insertString;
+	private String insertString = "";
 
 	/** The SQL type information for the insert columns */
-	@Nullable
-	private int[] insertTypes;
+	private int[] insertTypes = new int[0];
 
 
 	/**
@@ -224,15 +222,13 @@ public void setOverrideIncludeSynonymsDefault(boolean override) {
 	/**
 	 * Get the insert string to be used.
 	 */
-	@Nullable
 	public String getInsertString() {
 		return this.insertString;
 	}
 
 	/**
 	 * Get the array of {@link java.sql.Types} to be used for insert.
 	 */
-	@Nullable
 	public int[] getInsertTypes() {
 		return this.insertTypes;
 	}
diff --git a/spring-web/src/main/java/org/springframework/http/client/support/AsyncHttpAccessor.java b/spring-web/src/main/java/org/springframework/http/client/support/AsyncHttpAccessor.java
@@ -29,7 +29,8 @@
 /**
  * Base class for {@link org.springframework.web.client.AsyncRestTemplate}
  * and other HTTP accessing gateway helpers, defining common properties
- * such as the {@link org.springframework.http.client.AsyncClientHttpRequestFactory} to operate on.
+ * such as the {@link org.springframework.http.client.AsyncClientHttpRequestFactory}
+ * to operate on.
  *
  * <p>Not intended to be used directly. See
  * {@link org.springframework.web.client.AsyncRestTemplate}.
diff --git a/spring-web/src/main/java/org/springframework/web/context/support/LiveBeansViewServlet.java b/spring-web/src/main/java/org/springframework/web/context/support/LiveBeansViewServlet.java
@@ -57,7 +57,7 @@ protected LiveBeansView buildLiveBeansView() {
 	protected void doGet(HttpServletRequest request, HttpServletResponse response)
 			throws ServletException, IOException {
 
-		Assert.state(this.liveBeansView != null, "No LiveBeanViews available");
+		Assert.state(this.liveBeansView != null, "No LiveBeansView available");
 		String content = this.liveBeansView.getSnapshotAsJson();
 		response.setContentType("application/json");
 		response.setContentLength(content.length());
diff --git a/spring-web/src/test/java/org/springframework/web/filter/RelativeRedirectFilterTests.java b/spring-web/src/test/java/org/springframework/web/filter/RelativeRedirectFilterTests.java
@@ -20,11 +20,8 @@
 import javax.servlet.http.HttpServletResponseWrapper;
 
 import org.junit.Test;
-import org.junit.runner.RunWith;
 import org.mockito.InOrder;
-import org.mockito.Mock;
 import org.mockito.Mockito;
-import org.mockito.junit.MockitoJUnitRunner;
 
 import org.springframework.http.HttpHeaders;
 import org.springframework.http.HttpStatus;
@@ -38,14 +35,13 @@
  * Unit tests for {@link RelativeRedirectFilter}.
  *
  * @author Rob Winch
+ * @author Juergen Hoeller
  */
-@RunWith(MockitoJUnitRunner.class)
 public class RelativeRedirectFilterTests {
 
-	@Mock
-	HttpServletResponse response;
+	private RelativeRedirectFilter filter = new RelativeRedirectFilter();
 
-	RelativeRedirectFilter filter = new RelativeRedirectFilter();
+	private HttpServletResponse response = Mockito.mock(HttpServletResponse.class);
 
 
 	@Test(expected = IllegalArgumentException.class)
