[FSSDK-11006] remove assign function and use spreading (#979)

raju-opti · web-flow · commit 1adcbdb8dc43 · 2024-12-25T18:21:29.000+06:00
diff --git a/lib/core/audience_evaluator/index.ts b/lib/core/audience_evaluator/index.ts
@@ -44,10 +44,11 @@ export class AudienceEvaluator {
    * @constructor
    */
   constructor(UNSTABLE_conditionEvaluators: unknown) {
-    this.typeToEvaluatorMap = fns.assign({}, UNSTABLE_conditionEvaluators, {
+    this.typeToEvaluatorMap = {
+      ...UNSTABLE_conditionEvaluators as any,
       custom_attribute: customAttributeConditionEvaluator,
       third_party_dimension: odpSegmentsConditionEvaluator,
-    });
+    };
   }
 
   /**
diff --git a/lib/core/decision_service/index.ts b/lib/core/decision_service/index.ts
@@ -312,7 +312,7 @@ export class DecisionService {
 
     const userProfile = this.getUserProfile(userId) || {} as UserProfile;
     const attributeExperimentBucketMap = attributes[CONTROL_ATTRIBUTES.STICKY_BUCKETING_KEY];
-    return fns.assign({}, userProfile.experiment_bucket_map, attributeExperimentBucketMap);
+    return { ...userProfile.experiment_bucket_map, ...attributeExperimentBucketMap as any };
   }
 
   /**
diff --git a/lib/project_config/project_config.ts b/lib/project_config/project_config.ts
@@ -13,7 +13,7 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-import { find, objectEntries, objectValues, sprintf, assign, keyBy } from '../utils/fns';
+import { find, objectEntries, objectValues, sprintf, keyBy } from '../utils/fns';
 
 import { ERROR_MESSAGES, LOG_LEVEL, LOG_MESSAGES, FEATURE_VARIABLE_TYPES } from '../utils/enums';
 import configValidator from '../utils/config_validator';
@@ -99,27 +99,27 @@ const MODULE_NAME = 'PROJECT_CONFIG';
 
 // eslint-disable-next-line  @typescript-eslint/no-explicit-any
 function createMutationSafeDatafileCopy(datafile: any): ProjectConfig {
-  const datafileCopy = assign({}, datafile);
+  const datafileCopy = { ...datafile };
   datafileCopy.audiences = (datafile.audiences || []).map((audience: Audience) => {
-    return assign({}, audience);
+    return { ...audience };
   });
   datafileCopy.experiments = (datafile.experiments || []).map((experiment: Experiment) => {
-    return assign({}, experiment);
+    return { ...experiment };
   });
   datafileCopy.featureFlags = (datafile.featureFlags || []).map((featureFlag: FeatureFlag) => {
-    return assign({}, featureFlag);
+    return { ...featureFlag };
   });
   datafileCopy.groups = (datafile.groups || []).map((group: Group) => {
-    const groupCopy = assign({}, group);
+    const groupCopy = { ...group };
     groupCopy.experiments = (group.experiments || []).map(experiment => {
-      return assign({}, experiment);
+      return { ...experiment };
     });
     return groupCopy;
   });
   datafileCopy.rollouts = (datafile.rollouts || []).map((rollout: Rollout) => {
-    const rolloutCopy = assign({}, rollout);
+    const rolloutCopy = { ...rollout };
     rolloutCopy.experiments = (rollout.experiments || []).map(experiment => {
-      return assign({}, experiment);
+      return { ...experiment };
     });
     return rolloutCopy;
   });
@@ -148,8 +148,11 @@ export const createProjectConfig = function(datafileObj?: JSON, datafileStr: str
   (projectConfig.audiences || []).forEach(audience => {
     audience.conditions = JSON.parse(audience.conditions as string);
   });
-  projectConfig.audiencesById = keyBy(projectConfig.audiences, 'id');
-  assign(projectConfig.audiencesById, keyBy(projectConfig.typedAudiences, 'id'));
+
+  projectConfig.audiencesById = {
+    ...keyBy(projectConfig.audiences, 'id'),
+    ...keyBy(projectConfig.typedAudiences, 'id'),
+  }
 
   projectConfig.attributeKeyMap = keyBy(projectConfig.attributes, 'key');
   projectConfig.eventKeyMap = keyBy(projectConfig.events, 'key');
@@ -159,7 +162,8 @@ export const createProjectConfig = function(datafileObj?: JSON, datafileStr: str
   Object.keys(projectConfig.groupIdMap || {}).forEach(Id => {
     experiments = projectConfig.groupIdMap[Id].experiments;
     (experiments || []).forEach(experiment => {
-      projectConfig.experiments.push(assign(experiment, { groupId: Id }));
+      experiment.groupId = Id;
+      projectConfig.experiments.push(experiment);
     });
   });
 
@@ -226,7 +230,11 @@ export const createProjectConfig = function(datafileObj?: JSON, datafileStr: str
     experiment.variationKeyMap = keyBy(experiment.variations, 'key');
 
     // Creates { <variationId>: { key: <variationKey>, id: <variationId> } } mapping for quick lookup
-    assign(projectConfig.variationIdMap, keyBy(experiment.variations, 'id'));
+    projectConfig.variationIdMap = {
+      ...projectConfig.variationIdMap,
+      ...keyBy(experiment.variations, 'id')
+    };
+
     objectValues(experiment.variationKeyMap || {}).forEach(variation => {
       if (variation.variables) {
         projectConfig.variationVariableUsageMap[variation.id] = keyBy(variation.variables, 'id');
diff --git a/lib/utils/fns/index.tests.js b/lib/utils/fns/index.tests.js
@@ -84,22 +84,5 @@ describe('lib/utils/fns', function() {
         assert.isFalse(fns.isNumber(null));
       });
     });
-
-    describe('assign', function() {      
-      it('should return empty object when target is not provided', function() {
-        assert.deepEqual(fns.assign(), {});        
-      });
-
-      it('should copy correctly when Object.assign is available in environment', function() {        
-        assert.deepEqual(fns.assign({ a: 'a'}, {b: 'b'}), { a: 'a', b: 'b' });        
-      });
-
-      it('should copy correctly when Object.assign is not available in environment', function() {
-        var originalAssign = Object.assign;
-        Object.assign = null;
-        assert.deepEqual(fns.assign({ a: 'a'}, {b: 'b'}, {c: 'c'}), { a: 'a', b: 'b', c: 'c' });
-        Object.assign = originalAssign;
-      });
-    });
   });
 });
diff --git a/lib/utils/fns/index.ts b/lib/utils/fns/index.ts
@@ -17,30 +17,6 @@ import { v4 } from 'uuid';
 
 const MAX_SAFE_INTEGER_LIMIT = Math.pow(2, 53);
 
-// eslint-disable-next-line
-export function assign(target: any, ...sources: any[]): any {
-  if (!target) {
-    return {};
-  }
-  if (typeof Object.assign === 'function') {
-    return Object.assign(target, ...sources);
-  } else {
-    const to = Object(target);
-    for (let index = 0; index < sources.length; index++) {
-      const nextSource = sources[index];
-      if (nextSource !== null && nextSource !== undefined) {
-        for (const nextKey in nextSource) {
-          // Avoid bugs when hasOwnProperty is shadowed
-          if (Object.prototype.hasOwnProperty.call(nextSource, nextKey)) {
-            to[nextKey] = nextSource[nextKey];
-          }
-        }
-      }
-    }
-    return to;
-  }
-}
-
 export function currentTimestamp(): number {
   return Math.round(new Date().getTime());
 }
@@ -165,7 +141,6 @@ export function checkArrayEquality(arrayA: string[], arrayB: string[]): boolean
 }
 
 export default {
-  assign,
   checkArrayEquality,
   currentTimestamp,
   isSafeInteger,
diff --git a/lib/utils/local_storage/tryLocalStorage.ts b/lib/utils/local_storage/tryLocalStorage.ts

Original file line number	Diff line number	Diff line change
`@@ -312,7 +312,7 @@ export class DecisionService {`
`312`	`312`
`313`	`313`	`const userProfile = this.getUserProfile(userId) \|\| {} as UserProfile;`
`314`	`314`	`const attributeExperimentBucketMap = attributes[CONTROL_ATTRIBUTES.STICKY_BUCKETING_KEY];`
`315`		`- return fns.assign({}, userProfile.experiment_bucket_map, attributeExperimentBucketMap);`
	`315`	`+ return { ...userProfile.experiment_bucket_map, ...attributeExperimentBucketMap as any };`
`316`	`316`	`}`
`317`	`317`
`318`	`318`	`/**`