handle undefined include and exclude flags

raju-opti · raju-opti · commit 466dc8885fe6 · 2025-07-01T23:15:20.000+06:00
diff --git a/lib/project_config/project_config.spec.ts b/lib/project_config/project_config.spec.ts
@@ -442,6 +442,18 @@ describe('createProjectConfig - holdouts, feature toggle is on', () => {
     expect(configObj.excludedHoldouts).toEqual({});
     expect(configObj.flagHoldoutsMap).toEqual({});
   });
+
+  it('should handle undefined includeFlags and excludeFlags in holdout', function() {
+    const datafile = getHoldoutDatafile();
+    datafile.holdouts[0].includeFlags = undefined;
+    datafile.holdouts[0].excludeFlags = undefined;
+
+    const configObj = projectConfig.createProjectConfig(JSON.parse(JSON.stringify(datafile)));
+
+    expect(configObj.holdouts).toHaveLength(3);
+    expect(configObj.holdouts[0].includeFlags).toEqual([]);
+    expect(configObj.holdouts[0].excludeFlags).toEqual([]);
+  });
 });
 
 describe('getHoldoutsForFlag: feature toggle is on', () => {
diff --git a/lib/project_config/project_config.ts b/lib/project_config/project_config.ts
@@ -361,6 +361,14 @@ const parseHoldoutsConfig = (projectConfig: ProjectConfig): void => {
   projectConfig.flagHoldoutsMap = {};
 
   projectConfig.holdouts.forEach((holdout) => {
+    if (!holdout.includeFlags) {
+      holdout.includeFlags = [];
+    }
+
+    if (!holdout.excludeFlags) {
+      holdout.excludeFlags = [];
+    }
+
     holdout.variationKeyMap = keyBy(holdout.variations, 'key');
     if (holdout.includeFlags.length === 0) {
       projectConfig.globalHoldouts.push(holdout);
