Skip to content

Commit 0a0cdef

Browse files
committed
Fix test cases
1 parent 158aab3 commit 0a0cdef

File tree

2 files changed

+10
-1
lines changed

2 files changed

+10
-1
lines changed

tests/test_event_builder.py

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -86,6 +86,7 @@ def test_create_impression_event(self):
8686
'enrich_decisions': True,
8787
'anonymize_ip': False,
8888
'revision': '42',
89+
'region': 'US',
8990
}
9091

9192
with mock.patch('time.time', return_value=42.123), mock.patch(
@@ -141,6 +142,7 @@ def test_create_impression_event__with_attributes(self):
141142
'enrich_decisions': True,
142143
'anonymize_ip': False,
143144
'revision': '42',
145+
'region': 'US',
144146
}
145147

146148
with mock.patch('time.time', return_value=42.123), mock.patch(
@@ -194,6 +196,7 @@ def test_create_impression_event_when_attribute_is_not_in_datafile(self):
194196
'enrich_decisions': True,
195197
'anonymize_ip': False,
196198
'revision': '42',
199+
'region': 'US',
197200
}
198201

199202
with mock.patch('time.time', return_value=42.123), mock.patch(
@@ -250,6 +253,7 @@ def test_create_impression_event_calls_is_attribute_valid(self):
250253
'enrich_decisions': True,
251254
'anonymize_ip': False,
252255
'revision': '42',
256+
'region': 'US',
253257
}
254258

255259
def side_effect(*args, **kwargs):
@@ -328,6 +332,7 @@ def test_create_impression_event__with_user_agent_when_bot_filtering_is_enabled(
328332
'enrich_decisions': True,
329333
'anonymize_ip': False,
330334
'revision': '42',
335+
'region': 'US',
331336
}
332337

333338
with mock.patch('time.time', return_value=42.123), mock.patch(
@@ -392,6 +397,7 @@ def test_create_impression_event__with_empty_attributes_when_bot_filtering_is_en
392397
'enrich_decisions': True,
393398
'anonymize_ip': False,
394399
'revision': '42',
400+
'region': 'US',
395401
}
396402

397403
with mock.patch('time.time', return_value=42.123), mock.patch(
@@ -462,6 +468,7 @@ def test_create_impression_event__with_user_agent_when_bot_filtering_is_disabled
462468
'enrich_decisions': True,
463469
'anonymize_ip': False,
464470
'revision': '42',
471+
'region': 'US',
465472
}
466473

467474
with mock.patch('time.time', return_value=42.123), mock.patch(

tests/test_user_event_factory.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,8 +48,10 @@ def test_impression_event_with_region_eu(self):
4848
experiment = self.project_config.get_experiment_from_key('test_experiment')
4949
user_id = 'test_user'
5050

51+
project_config.region = 'EU'
52+
5153
impression_event = UserEventFactory.create_impression_event(
52-
project_config, experiment, '111128', '', 'rule_key', 'rule_type', True, user_id, None, region='EU'
54+
project_config, experiment, '111128', '', 'rule_key', 'rule_type', True, user_id, None
5355
)
5456

5557
self.assertEqual(self.project_config.region, impression_event.event_context.region)

0 commit comments

Comments
 (0)