update: improve error logging for CMAB decision fetch failures

FarhanAnjum-opti · FarhanAnjum-opti · commit aca7df4682d2 · 2025-07-03T18:39:45.000+06:00
diff --git a/optimizely/decision_service.py b/optimizely/decision_service.py
@@ -185,11 +185,10 @@ def _get_decision_for_cmab_experiment(
             }
         except Exception as e:
             error_message = Errors.CMAB_FETCH_FAILED_DETAILED.format(
-                experiment.key,
-                str(e)
+                experiment.key
             )
             if self.logger:
-                self.logger.error(error_message)
+                self.logger.error(f'{error_message} {str(e)}')
             return {
                 "error": True,
                 "result": None,
diff --git a/optimizely/helpers/enums.py b/optimizely/helpers/enums.py
@@ -127,9 +127,9 @@ class Errors:
     ODP_INVALID_DATA: Final = 'ODP data is not valid.'
     ODP_INVALID_ACTION: Final = 'ODP action is not valid (cannot be empty).'
     MISSING_SDK_KEY: Final = 'SDK key not provided/cannot be found in the datafile.'
-    CMAB_FETCH_FAILED: Final = 'CMAB decision fetch failed with status: {}'
-    INVALID_CMAB_FETCH_RESPONSE: Final = 'Invalid CMAB fetch response'
-    CMAB_FETCH_FAILED_DETAILED: Final = 'Failed to fetch CMAB decision for experiment key "{}" - {}'
+    CMAB_FETCH_FAILED: Final = 'CMAB decision fetch failed with status: {}.'
+    INVALID_CMAB_FETCH_RESPONSE: Final = 'Invalid CMAB fetch response.'
+    CMAB_FETCH_FAILED_DETAILED: Final = 'Failed to fetch CMAB data for experiment {}.'
 
 
 class ForcedDecisionLogs:

Original file line number	Diff line number	Diff line change
`@@ -185,11 +185,10 @@ def _get_decision_for_cmab_experiment(`
`185`	`185`	`}`
`186`	`186`	`except Exception as e:`
`187`	`187`	`error_message = Errors.CMAB_FETCH_FAILED_DETAILED.format(`
`188`		`- experiment.key,`
`189`		`- str(e)`
	`188`	`+ experiment.key`
`190`	`189`	`)`
`191`	`190`	`if self.logger:`
`192`		`- self.logger.error(error_message)`
	`191`	`+ self.logger.error(f'{error_message} {str(e)}')`
`193`	`192`	`return {`
`194`	`193`	`"error": True,`
`195`	`194`	`"result": None,`