Fixing tests for Python 3 (#38)

aliabbasrizvi · web-flow · commit b60ed2fbd061 · 2017-03-20T17:05:05.000-07:00
diff --git a/tests/test_event_builder.py b/tests/test_event_builder.py
@@ -446,6 +446,9 @@ def test_create_conversion_event__with_event_value(self):
         'test_event', 'test_user', {'test_attribute': 'test_value'}, {'revenue': 4200, 'non-revenue': 'abc'},
         [self.project_config.get_experiment_from_key('test_experiment')]
       )
+
+    # Sort event features based on ID
+    event_obj.params['eventFeatures'] = sorted(event_obj.params['eventFeatures'], key=lambda x: x.get('id'))
     self._validate_event_object(event_obj,
                                 event_builder.EventBuilderV2.CONVERSION_ENDPOINT,
                                 expected_params,
@@ -504,6 +507,8 @@ def test_create_conversion_event__with_invalid_event_value(self):
         'test_event', 'test_user', {'test_attribute': 'test_value'}, {'revenue': '4200', 'non-revenue': 'abc'},
         [self.project_config.get_experiment_from_key('test_experiment')]
       )
+    # Sort event features based on ID
+    event_obj.params['eventFeatures'] = sorted(event_obj.params['eventFeatures'], key=lambda x: x.get('id'))
     self._validate_event_object(event_obj,
                                 event_builder.EventBuilderV2.CONVERSION_ENDPOINT,
                                 expected_params,
diff --git a/tests/test_optimizely.py b/tests/test_optimizely.py
@@ -804,6 +804,11 @@ def test_track__with_event_value(self):
     }
     mock_bucket.assert_called_once_with(self.project_config.get_experiment_from_key('test_experiment'), 'test_user')
     self.assertEqual(1, mock_dispatch_event.call_count)
+
+    # Sort event features based on ID
+    mock_dispatch_event.call_args[0][0].params['eventFeatures'] = sorted(
+      mock_dispatch_event.call_args[0][0].params['eventFeatures'], key=lambda x: x.get('id')
+    )
     self._validate_event_object(mock_dispatch_event.call_args[0][0], 'https://logx.optimizely.com/log/event',
                                 expected_params, 'POST', {'Content-Type': 'application/json'})
 
