Updating default event dispatcher to actually raise exceptions (#140)

aliabbasrizvi · web-flow · commit f3e395a648e7 · 2018-08-29T12:09:40.000-07:00
diff --git a/optimizely/event_dispatcher.py b/optimizely/event_dispatcher.py
@@ -34,8 +34,11 @@ def dispatch_event(event):
 
     try:
       if event.http_verb == enums.HTTPVerbs.GET:
-        requests.get(event.url, params=event.params, timeout=REQUEST_TIMEOUT)
+        requests.get(event.url, params=event.params, timeout=REQUEST_TIMEOUT).raise_for_status()
       elif event.http_verb == enums.HTTPVerbs.POST:
-        requests.post(event.url, data=json.dumps(event.params), headers=event.headers, timeout=REQUEST_TIMEOUT)
+        requests.post(
+          event.url, data=json.dumps(event.params), headers=event.headers, timeout=REQUEST_TIMEOUT
+        ).raise_for_status()
+
     except request_exception.RequestException as error:
       logging.error('Dispatch event failed. Error: %s' % str(error))
