Skip to content

[FSSDK-11458] Python - Add SDK Multi-Region Support for Data Hosting #459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 25 commits into
base: master
Choose a base branch
from
Open

[FSSDK-11458] Python - Add SDK Multi-Region Support for Data Hosting #459

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
d9e8f83
[FSSDK-11458] Python - Add SDK Multi-Region Support for Data Hosting
esrakartalOpt Jul 2, 2025
0866962
Fix lint issues
esrakartalOpt Jul 2, 2025
5a0e19d
Fix lint issue
esrakartalOpt Jul 2, 2025
730fede
Fix errors
esrakartalOpt Jul 2, 2025
47ccb94
Add region on base test
esrakartalOpt Jul 2, 2025
a7d74ac
Update Region as enum
esrakartalOpt Jul 2, 2025
8a65e0f
Delete blank lines
esrakartalOpt Jul 2, 2025
24d2fcd
Fix lint issue
esrakartalOpt Jul 2, 2025
ba5beee
Fix lint issue
esrakartalOpt Jul 2, 2025
17c9280
Fix test errors
esrakartalOpt Jul 2, 2025
155ab25
Add enum
esrakartalOpt Jul 2, 2025
ba049b6
Fix region value
esrakartalOpt Jul 2, 2025
a777fa0
Fix type issue
esrakartalOpt Jul 2, 2025
c1f1693
Correct the event url
esrakartalOpt Jul 2, 2025
6de0889
Add region in params
esrakartalOpt Jul 2, 2025
83afabe
Fix region param
esrakartalOpt Jul 2, 2025
158aab3
Add region to create
esrakartalOpt Jul 2, 2025
0a0cdef
Fix test cases
esrakartalOpt Jul 2, 2025
f68d678
Fix test cases
esrakartalOpt Jul 2, 2025
81cd042
Fix lint
esrakartalOpt Jul 2, 2025
9d2c892
Add region
esrakartalOpt Jul 2, 2025
3c1332f
Fix test cases
esrakartalOpt Jul 4, 2025
11523cf
Fix tests
esrakartalOpt Jul 4, 2025
1af68db
Cast to string
esrakartalOpt Jul 4, 2025
7a09f1d
Fix tests
esrakartalOpt Jul 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix lint issues
  • Loading branch information
@esrakartalOpt
esrakartalOpt committed Jul 2, 2025
commit 08669627c058d2e59f29582863b9958e74af851f
12 changes: 10 additions & 2 deletions optimizely/event/user_event_factory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,11 @@ def create_impression_event(
variation = project_config.get_variation_from_id_by_experiment_id(experiment_id, variation_id)

event_context = user_event.EventContext(
project_config.account_id, project_config.project_id, project_config.revision, project_config.anonymize_ip, project_config.region
project_config.account_id,
project_config.project_id,
project_config.revision,
project_config.anonymize_ip,
project_config.region
)

return user_event.ImpressionEvent(
Expand Down Expand Up @@ -115,7 +119,11 @@ def create_conversion_event(
"""

event_context = user_event.EventContext(
project_config.account_id, project_config.project_id, project_config.revision, project_config.anonymize_ip, project_config.region
project_config.account_id,
project_config.project_id,
project_config.revision,
project_config.anonymize_ip,
project_config.region
)

return user_event.ConversionEvent(
Expand Down
3 changes: 0 additions & 3 deletions tests/test_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,6 @@ def test_region_when_no_region(self):
project_config = opt_obj.config_manager.get_config()
self.assertEqual(project_config.region, Region.US)


def test_region_when_specified_in_datafile(self):
""" Test that region is set to 'US' when specified in the config. """
config_dict_us = copy.deepcopy(self.config_dict_with_multiple_experiments)
Expand All @@ -177,8 +176,6 @@ def test_region_when_specified_in_datafile(self):
project_config_eu = opt_obj_eu.config_manager.get_config()
self.assertEqual(project_config_eu.region, Region.EU)



def test_cmab_field_population(self):
""" Test that the cmab field is populated correctly in experiments."""

Expand Down