Add comment about cmab error handling

optimizely · muzahidul-opti · Jul 14, 2025 · Jun 18, 2025 · Jun 18, 2025 · Jun 20, 2025
commit 45140d91b6a09517884ff668f683bf7e3fb12f5c
diff --git a/Sources/Implementation/DefaultDecisionService.swift b/Sources/Implementation/DefaultDecisionService.swift
@@ -453,8 +453,13 @@ class DefaultDecisionService: OPTDecisionService {
                                                                       options: options)
                 reasons.merge(decisionResponse.reasons)
                 if let result = decisionResponse.result {
-                    if result.cmabError || result.variation != nil {
-                        let featureDecision = FeatureDecision(experiment: experiment, variation: result.variation, source: Constants.DecisionSource.featureTest.rawValue, cmabUUID: result.cmabUUID)
+                    if result.cmabError {
+                        // For CMAB - we're supposed to get decision from the server.
+                        // If failed, return decision with nil variation, so the client can take care of them.
+                        let featureDecision = FeatureDecision(experiment: experiment, variation: nil, source: Constants.DecisionSource.featureTest.rawValue)
+                        return DecisionResponse(result: featureDecision, reasons: reasons)
+                    } else if let variation = result.variation {
+                        let featureDecision = FeatureDecision(experiment: experiment, variation: variation, source: Constants.DecisionSource.featureTest.rawValue)
                         return DecisionResponse(result: featureDecision, reasons: reasons)
                     }
                 }