Improve error messages

N2D4 · N2D4 · commit 9d0cb86677b5 · 2024-08-31T17:48:28.000-07:00
diff --git a/apps/backend/src/route-handlers/smart-request.tsx b/apps/backend/src/route-handlers/smart-request.tsx
@@ -227,14 +227,14 @@ async function parseAuth(req: NextRequest): Promise<SmartRequestAuth | null> {
         break;
       }
       default: {
-        throw new StackAssertionError(`Unexpected request type: ${requestType}. We should've filtered this earlier`);
+        throw new StackAssertionError(`Unexpected request type: ${requestType}. This should never happen because we should've filtered this earlier`);
       }
     }
   }
 
   const project = await getProject(projectId);
   if (!project) {
-    throw new StackAssertionError("Project not found; this should never happen because having a project ID should guarantee a project", { projectId });
+    throw new StackAssertionError("Project not found; this should never happen because passing the checks until here should guarantee that the project exists and that access to it is granted", { projectId });
   }
 
   let user = null;

Original file line number	Diff line number	Diff line change
`@@ -227,14 +227,14 @@ async function parseAuth(req: NextRequest): Promise<SmartRequestAuth \| null> {`
`227`	`227`	`break;`
`228`	`228`	`}`
`229`	`229`	`default: {`
`230`		- throw new StackAssertionError(`Unexpected request type: ${requestType}. We should've filtered this earlier`);
	`230`	+ throw new StackAssertionError(`Unexpected request type: ${requestType}. This should never happen because we should've filtered this earlier`);
`231`	`231`	`}`
`232`	`232`	`}`
`233`	`233`	`}`
`234`	`234`
`235`	`235`	`const project = await getProject(projectId);`
`236`	`236`	`if (!project) {`
`237`		`- throw new StackAssertionError("Project not found; this should never happen because having a project ID should guarantee a project", { projectId });`
	`237`	`+ throw new StackAssertionError("Project not found; this should never happen because passing the checks until here should guarantee that the project exists and that access to it is granted", { projectId });`
`238`	`238`	`}`
`239`	`239`
`240`	`240`	`let user = null;`